From patchwork Wed Feb 19 07:26:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 38221 Received: (qmail 92359 invoked by alias); 19 Feb 2020 07:26:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 92351 invoked by uid 89); 19 Feb 2020 07:26:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Feb 2020 07:26:08 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 1F412AD93 for ; Wed, 19 Feb 2020 07:26:06 +0000 (UTC) Date: Wed, 19 Feb 2020 08:26:04 +0100 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Be quiet about missing prelink in solib-overlap.exp Message-ID: <20200219072603.GA2019@delia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes Hi, When running gdb.base/solib-overlap.exp, I get: ... Running src/gdb/testsuite/gdb.base/solib-overlap.exp ... sh: prelink: command not found === gdb Summary === nr of untested testcases 1 ... The verbose output on stdout/stderr is due to using system to execute prelink, which also means that the output is not captured in gdb.log and gdb.sum. Fix this by using exec instead of system. Tested on x86_64-linux, with: - no prelink installed, and - a fake prelink installed, using "cp /usr/bin/echo ~/bin/prelink". Committed to trunk. Thanks, - Tom [gdb/testsuite] Be quiet about missing prelink in solib-overlap.exp gdb/testsuite/ChangeLog: 2020-02-19 Tom de Vries * gdb.base/solib-overlap.exp: Use exec instead of system to execute prelink. --- gdb/testsuite/gdb.base/solib-overlap.exp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.base/solib-overlap.exp b/gdb/testsuite/gdb.base/solib-overlap.exp index 661d6cfa73..a7064a1316 100644 --- a/gdb/testsuite/gdb.base/solib-overlap.exp +++ b/gdb/testsuite/gdb.base/solib-overlap.exp @@ -74,9 +74,10 @@ foreach prelink_lib1 {0x40000000 0x50000000} { with_test_prefix "$prelink_lib1" return -1 } - if {[catch "system \"prelink -N -r ${prelink_lib1} ${binfile_lib1}\""] != 0 - || [catch "system \"prelink -N -r ${prelink_lib2} ${binfile_lib2}\""] != 0} { + if {[catch "exec prelink -N -r ${prelink_lib1} ${binfile_lib1}" output] != 0 + || [catch "exec prelink -N -r ${prelink_lib2} ${binfile_lib2}" output] != 0} { # Maybe we don't have prelink. + verbose -log "prelink failed: $output" untested "could not prelink ${binfile_lib1_test_msg} or ${binfile_lib2_test_msg}." return -1 }