diff mbox

[8/8] Move the frame data to the BFD when possible

Message ID 20200208152758.29385-9-tom@tromey.com
State New
Headers show

Commit Message

Tom Tromey Feb. 8, 2020, 3:27 p.m. UTC
Now that comp_unit and the remaining frame data are all independent of
the objfile, it can all be stored on the BFD and shared across
inferiors.

As with other code doing this same thing, care must be taken to not
share the data when the objfile requires relocations.  So, two keys
are used: one for the BFD and one for the objfile, and
gdb_bfd_requires_relocations is used to differentiate between the two
cases.

gdb/ChangeLog
2020-02-08  Tom Tromey  <tom@tromey.com>

	* dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
	(dwarf2_frame_objfile_data): Add comment.
	(find_comp_unit, set_comp_unit): New functions.
	(dwarf2_frame_find_fde): Use find_comp_unit.
	(dwarf2_build_frame_info): Use set_comp_unit.

Change-Id: I50f5e1220c3f6b2992a15d5112fe474fb2904511
---
 gdb/ChangeLog      |  8 ++++++++
 gdb/dwarf2/frame.c | 37 +++++++++++++++++++++++++++++++++----
 2 files changed, 41 insertions(+), 4 deletions(-)

Comments

Luis Machado Feb. 11, 2020, 10:45 a.m. UTC | #1
On 2/8/20 12:27 PM, Tom Tromey wrote:
> Now that comp_unit and the remaining frame data are all independent of
> the objfile, it can all be stored on the BFD and shared across
> inferiors.
> 
> As with other code doing this same thing, care must be taken to not
> share the data when the objfile requires relocations.  So, two keys
> are used: one for the BFD and one for the objfile, and
> gdb_bfd_requires_relocations is used to differentiate between the two
> cases.
> 
> gdb/ChangeLog
> 2020-02-08  Tom Tromey  <tom@tromey.com>
> 
> 	* dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
> 	(dwarf2_frame_objfile_data): Add comment.
> 	(find_comp_unit, set_comp_unit): New functions.
> 	(dwarf2_frame_find_fde): Use find_comp_unit.
> 	(dwarf2_build_frame_info): Use set_comp_unit.
> 
> Change-Id: I50f5e1220c3f6b2992a15d5112fe474fb2904511
> ---
>   gdb/ChangeLog      |  8 ++++++++
>   gdb/dwarf2/frame.c | 37 +++++++++++++++++++++++++++++++++----
>   2 files changed, 41 insertions(+), 4 deletions(-)
> 
> diff --git a/gdb/dwarf2/frame.c b/gdb/dwarf2/frame.c
> index 2c35016e2d9..25dddb7b1ae 100644
> --- a/gdb/dwarf2/frame.c
> +++ b/gdb/dwarf2/frame.c
> @@ -1475,8 +1475,14 @@ dwarf2_frame_cfa (struct frame_info *this_frame)
>     return get_frame_base (this_frame);
>   }
>   
> -const struct objfile_key<comp_unit> dwarf2_frame_objfile_data;
> +/* We store the frame data on the BFD, when it is independent of the

when -> where?

> +   address space and so can be shared.  */
> +const struct bfd_key<comp_unit> dwarf2_frame_bfd_data;
>   
> +/* If any BFD sections require relocations (note; really should be if
> +   any debug info requires relocations), then we store the frame data
> +   on the objfile instead, and do not share it.  */
> +const struct objfile_key<comp_unit> dwarf2_frame_objfile_data;
>   
>   
>   /* Pointer encoding helper functions.  */
> @@ -1630,6 +1636,29 @@ bsearch_fde_cmp (const dwarf2_fde *fde, CORE_ADDR seek_pc)
>     return 1;
>   }
>   
> +/* Find an existing comp_unit for an objfile, if any.  */
> +
> +static comp_unit *
> +find_comp_unit (struct objfile *objfile)
> +{
> +  bfd *abfd = objfile->obfd;
> +  if (gdb_bfd_requires_relocations (abfd))
> +    return dwarf2_frame_bfd_data.get (abfd);
> +  return dwarf2_frame_objfile_data.get (objfile);
> +}
> +
> +/* Store the comp_unit on OBJFILE, or the corresponding BFD, as
> +   appropriate.  */
> +
> +static void
> +set_comp_unit (struct objfile *objfile, struct comp_unit *unit)
> +{
> +  bfd *abfd = objfile->obfd;
> +  if (gdb_bfd_requires_relocations (abfd))
> +    return dwarf2_frame_bfd_data.set (abfd, unit);
> +  return dwarf2_frame_objfile_data.set (objfile, unit);
> +}
> +
>   /* Find the FDE for *PC.  Return a pointer to the FDE, and store the
>      initial location associated with it into *PC.  */
>   
> @@ -1641,11 +1670,11 @@ dwarf2_frame_find_fde (CORE_ADDR *pc, CORE_ADDR *out_offset)
>         CORE_ADDR offset;
>         CORE_ADDR seek_pc;
>   
> -      comp_unit *unit = dwarf2_frame_objfile_data.get (objfile);
> +      comp_unit *unit = find_comp_unit (objfile);
>         if (unit == NULL)
>   	{
>   	  dwarf2_build_frame_info (objfile);
> -	  unit = dwarf2_frame_objfile_data.get (objfile);
> +	  unit = find_comp_unit (objfile);
>   	}
>         gdb_assert (unit != NULL);
>   
> @@ -2261,7 +2290,7 @@ dwarf2_build_frame_info (struct objfile *objfile)
>         unit->fde_table.shrink_to_fit ();
>       }
>   
> -  dwarf2_frame_objfile_data.set (objfile, unit);
> +  set_comp_unit (objfile, unit);
>   }
>   
>   /* Handle 'maintenance show dwarf unwinders'.  */
> 

Otherwise LGTM.
Tom Tromey Feb. 12, 2020, 12:30 a.m. UTC | #2
>>>>> "Luis" == Luis Machado <luis.machado@linaro.org> writes:

>> -const struct objfile_key<comp_unit> dwarf2_frame_objfile_data;
>> +/* We store the frame data on the BFD, when it is independent of the

Luis> when -> where?

More like "in the case where", but I just reworded it to:

/* We store the frame data on the BFD.  This is only done if it is
   independent of the address space and so can be shared.  */
const struct bfd_key<comp_unit> dwarf2_frame_bfd_data;

Tom
diff mbox

Patch

diff --git a/gdb/dwarf2/frame.c b/gdb/dwarf2/frame.c
index 2c35016e2d9..25dddb7b1ae 100644
--- a/gdb/dwarf2/frame.c
+++ b/gdb/dwarf2/frame.c
@@ -1475,8 +1475,14 @@  dwarf2_frame_cfa (struct frame_info *this_frame)
   return get_frame_base (this_frame);
 }
 
-const struct objfile_key<comp_unit> dwarf2_frame_objfile_data;
+/* We store the frame data on the BFD, when it is independent of the
+   address space and so can be shared.  */
+const struct bfd_key<comp_unit> dwarf2_frame_bfd_data;
 
+/* If any BFD sections require relocations (note; really should be if
+   any debug info requires relocations), then we store the frame data
+   on the objfile instead, and do not share it.  */
+const struct objfile_key<comp_unit> dwarf2_frame_objfile_data;
 
 
 /* Pointer encoding helper functions.  */
@@ -1630,6 +1636,29 @@  bsearch_fde_cmp (const dwarf2_fde *fde, CORE_ADDR seek_pc)
   return 1;
 }
 
+/* Find an existing comp_unit for an objfile, if any.  */
+
+static comp_unit *
+find_comp_unit (struct objfile *objfile)
+{
+  bfd *abfd = objfile->obfd;
+  if (gdb_bfd_requires_relocations (abfd))
+    return dwarf2_frame_bfd_data.get (abfd);
+  return dwarf2_frame_objfile_data.get (objfile);
+}
+
+/* Store the comp_unit on OBJFILE, or the corresponding BFD, as
+   appropriate.  */
+
+static void
+set_comp_unit (struct objfile *objfile, struct comp_unit *unit)
+{
+  bfd *abfd = objfile->obfd;
+  if (gdb_bfd_requires_relocations (abfd))
+    return dwarf2_frame_bfd_data.set (abfd, unit);
+  return dwarf2_frame_objfile_data.set (objfile, unit);
+}
+
 /* Find the FDE for *PC.  Return a pointer to the FDE, and store the
    initial location associated with it into *PC.  */
 
@@ -1641,11 +1670,11 @@  dwarf2_frame_find_fde (CORE_ADDR *pc, CORE_ADDR *out_offset)
       CORE_ADDR offset;
       CORE_ADDR seek_pc;
 
-      comp_unit *unit = dwarf2_frame_objfile_data.get (objfile);
+      comp_unit *unit = find_comp_unit (objfile);
       if (unit == NULL)
 	{
 	  dwarf2_build_frame_info (objfile);
-	  unit = dwarf2_frame_objfile_data.get (objfile);
+	  unit = find_comp_unit (objfile);
 	}
       gdb_assert (unit != NULL);
 
@@ -2261,7 +2290,7 @@  dwarf2_build_frame_info (struct objfile *objfile)
       unit->fde_table.shrink_to_fit ();
     }
 
-  dwarf2_frame_objfile_data.set (objfile, unit);
+  set_comp_unit (objfile, unit);
 }
 
 /* Handle 'maintenance show dwarf unwinders'.  */