From patchwork Tue Feb 4 16:37:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 37676 Received: (qmail 127260 invoked by alias); 4 Feb 2020 16:37:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 127251 invoked by uid 89); 4 Feb 2020 16:37:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 04 Feb 2020 16:37:13 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 00A8120555; Tue, 4 Feb 2020 11:37:09 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id F33E720178; Tue, 4 Feb 2020 11:37:07 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id D11CA2816C; Tue, 4 Feb 2020 11:37:07 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Tue, 4 Feb 2020 11:37:07 -0500 From: "Sourceware to Gerrit sync (Code Review)" To: Tom de Vries , Simon Marchi , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [pushed] [gdb/testsuite] Add note to 'Race detection' entry in README X-Gerrit-Change-Id: I12ef2f0ec35abc5a0221585bf30e5f4f0616aa7c X-Gerrit-Change-Number: 762 X-Gerrit-ChangeURL: X-Gerrit-Commit: f8dcc90b6030b641fa7b0b33e4203498bbb0f0e0 In-Reply-To: References: Reply-To: noreply@gnutoolchain-gerrit.osci.io, simon.marchi@polymtl.ca, tdevries@suse.de, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Message-Id: <20200204163707.D11CA2816C@gnutoolchain-gerrit.osci.io> The original change was created by Tom de Vries. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/762 ...................................................................... [gdb/testsuite] Add note to 'Race detection' entry in README Add note to 'Race detection' entry in README about the possibility that check-read1 makes failing tests pass. gdb/testsuite/ChangeLog: 2020-02-04 Tom de Vries * README (Race detection): Add note. Change-Id: I12ef2f0ec35abc5a0221585bf30e5f4f0616aa7c --- M gdb/testsuite/ChangeLog M gdb/testsuite/README 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 8fcf67b..cd496e7 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2020-02-04 Tom de Vries + * README (Race detection): Add note. + +2020-02-04 Tom de Vries + * lib/gdb.exp (inferior_exited_re): Use "\[^\n\r\]*" instead of ".*". 2020-02-04 Tom de Vries diff --git a/gdb/testsuite/README b/gdb/testsuite/README index 4795df1..3e42526 100644 --- a/gdb/testsuite/README +++ b/gdb/testsuite/README @@ -352,6 +352,13 @@ make -j10 check-read1 TESTS="*/paginate-*.exp" make -j10 check READ1="1" +Note: While the intention is to detect races and make otherwise passing tests +fail, it can also have the effect of making otherwise failing tests pass. +This happens f.i. if the test is trying to match a gdb prompt using an end of +input marker "${gdb_prompt} $" and there is output after the gdb prompt. This +may either pass or fail in normal operation, but using check-read1 will ensure +that it passes. + Testsuite Configuration ***********************