From patchwork Sun Jan 26 21:51:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 37549 Received: (qmail 105916 invoked by alias); 26 Jan 2020 21:51:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 105903 invoked by uid 89); 26 Jan 2020 21:51:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=M68K, H*f:sk:gerrit., luis.machado@linaro.org, sk:luis.ma X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 26 Jan 2020 21:51:11 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id B176220393; Sun, 26 Jan 2020 16:51:09 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 935B8201AD; Sun, 26 Jan 2020 16:51:07 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 6C8FC20AF7; Sun, 26 Jan 2020 16:51:07 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Sun, 26 Jan 2020 16:51:06 -0500 From: "Sourceware to Gerrit sync (Code Review)" To: Tom Tromey , Luis Machado , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [pushed] Document m68k floating point feature correspondence X-Gerrit-Change-Id: I4cd86acbe3449a29ce38327524c508c206b25b8f X-Gerrit-Change-Number: 281 X-Gerrit-ChangeURL: X-Gerrit-Commit: b7d2fe148e7662875b9d64c0d1e25fa853d26b5e In-Reply-To: References: Reply-To: noreply@gnutoolchain-gerrit.osci.io, tromey@sourceware.org, luis.machado@linaro.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Message-Id: <20200126215107.6C8FC20AF7@gnutoolchain-gerrit.osci.io> The original change was created by Tom Tromey. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/281 ...................................................................... Document m68k floating point feature correspondence From what I can tell, The m68k floating point target feature should apparently always be called "org.gnu.gdb.coldfire.fp" -- even when the primary feature is not "coldfire", because m68k_gdbarch_init only checks for this feature when assigning register numbers. However, the floating point registers are expected to match what gdb thinks are the register sizes for the primary feature. For example, if the main feature is "coldfire", then the floating point registers should be 64 bits. See this note for some an instance of this confusion: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg04564.html This patch documents the oddity. Let me know what you think. An alternate approach here might be to make gdb adapt to the register sizes as actually reported. I'm not sure if this makes sense or not. gdb/doc/ChangeLog 2020-01-26 Tom Tromey * gdb.texinfo (M68K Features): Document floating-point feature correspondence. Change-Id: I4cd86acbe3449a29ce38327524c508c206b25b8f --- M gdb/doc/ChangeLog M gdb/doc/gdb.texinfo 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 139951f..4900480 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,8 @@ +2020-01-26 Tom Tromey + + * gdb.texinfo (M68K Features): Document floating-point feature + correspondence. + 2020-01-25 Philippe Waroquiers * gdb.texinfo (Attach): Document the new option and the diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 2a38b03..a2866a2 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -45230,6 +45230,12 @@ This feature is optional. If present, it should contain registers @samp{fp0} through @samp{fp7}, @samp{fpcontrol}, @samp{fpstatus} and @samp{fpiaddr}. + +Note that, despite the fact that this feature's name says +@samp{coldfire}, it is used to describe any floating point registers. +The size of the registers must match the main m68k flavor; so, for +example, if the primary feature is reported as @samp{coldfire}, then +64-bit floating point registers are required. @end table @node NDS32 Features