From patchwork Thu Jan 23 14:55:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Biesinger X-Patchwork-Id: 37513 Received: (qmail 20294 invoked by alias); 23 Jan 2020 14:55:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 20283 invoked by uid 89); 23 Jan 2020 14:55:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mail-wr1-f66.google.com Received: from mail-wr1-f66.google.com (HELO mail-wr1-f66.google.com) (209.85.221.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Jan 2020 14:55:26 +0000 Received: by mail-wr1-f66.google.com with SMTP id w15so3418923wru.4 for ; Thu, 23 Jan 2020 06:55:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZHE+TmlfdOQwD8faqVCBSuhxRVgxQu4Snp2NFsEutqo=; b=Fb0NRwvhlCcocOqFy/HXQhYW2pXJJPno+yCbxOm8pki1vGjyCLATlP+6nhxFO1xAbT y9joXixxyniq+TvQQ1V1RBIjWO2ZXwqgUS8U7YBFnVxP6jVRZGdcfsVBqiv3WKIC6c6x nxsHsEVtFrOeuy6G5MgA1vWqeg5Kh+nV8kRN4= Return-Path: Received: from cbiesinger.roam.corp.google.com (fanzine.igalia.com. [178.60.130.6]) by smtp.googlemail.com with ESMTPSA id 124sm3166450wmc.29.2020.01.23.06.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2020 06:55:23 -0800 (PST) From: cbiesinger@chromium.org To: gdb-patches@sourceware.org Cc: Christian Biesinger Subject: [PATCH] Update comments about removed function Date: Thu, 23 Jan 2020 15:55:19 +0100 Message-Id: <20200123145519.197813-1-cbiesinger@chromium.org> MIME-Version: 1.0 From: Christian Biesinger regset_from_core_sections doesn't exist anymore; it has been replaced by the iterate_over_regset_sections gdbarch method. Update comments accordingly to not confuse readers. gdb/ChangeLog: 2020-01-23 Christian Biesinger * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections): Update comment. * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections): Likewise. * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise. * gdbcore.h (deprecated_add_core_fns): Update comment to point to the correct replacement (iterate_over_regset_sections). * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections): Update comment. Change-Id: I5eea4d18e15edae5d6dfd5d0d6241e5b2ae40daa --- gdb/aarch64-fbsd-tdep.c | 2 +- gdb/aarch64-linux-tdep.c | 2 +- gdb/arm-fbsd-tdep.c | 2 +- gdb/gdbcore.h | 3 +-- gdb/riscv-fbsd-tdep.c | 2 +- 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/gdb/aarch64-fbsd-tdep.c b/gdb/aarch64-fbsd-tdep.c index b923c5c474..0d41198ecd 100644 --- a/gdb/aarch64-fbsd-tdep.c +++ b/gdb/aarch64-fbsd-tdep.c @@ -134,7 +134,7 @@ const struct regset aarch64_fbsd_fpregset = regcache_supply_regset, regcache_collect_regset }; -/* Implement the "regset_from_core_section" gdbarch method. */ +/* Implement the "iterate_over_regset_sections" gdbarch method. */ static void aarch64_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch, diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c index 67046c4271..34ba0d87ba 100644 --- a/gdb/aarch64-linux-tdep.c +++ b/gdb/aarch64-linux-tdep.c @@ -582,7 +582,7 @@ aarch64_linux_collect_sve_regset (const struct regset *regset, size - SVE_HEADER_SIZE); } -/* Implement the "regset_from_core_section" gdbarch method. */ +/* Implement the "iterate_over_regset_sections" gdbarch method. */ static void aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch, diff --git a/gdb/arm-fbsd-tdep.c b/gdb/arm-fbsd-tdep.c index 417a805e67..de94d06c70 100644 --- a/gdb/arm-fbsd-tdep.c +++ b/gdb/arm-fbsd-tdep.c @@ -150,7 +150,7 @@ const struct regset arm_fbsd_vfpregset = regcache_supply_regset, regcache_collect_regset }; -/* Implement the "regset_from_core_section" gdbarch method. */ +/* Implement the "iterate_over_regset_sections" gdbarch method. */ static void arm_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch, diff --git a/gdb/gdbcore.h b/gdb/gdbcore.h index 66e81dfe95..0a69d36ad7 100644 --- a/gdb/gdbcore.h +++ b/gdb/gdbcore.h @@ -269,8 +269,7 @@ private: std::string m_storage; }; -/* NOTE: cagney/2004-04-05: Replaced by "regset.h" and - regset_from_core_section(). */ +/* Replaced by the "iterate_over_regset_sections" gdbarch method. */ extern void deprecated_add_core_fns (struct core_fns *cf); extern int default_core_sniffer (struct core_fns *cf, bfd * abfd); extern int default_check_format (bfd * abfd); diff --git a/gdb/riscv-fbsd-tdep.c b/gdb/riscv-fbsd-tdep.c index 8a9295904d..6e0eb2bb78 100644 --- a/gdb/riscv-fbsd-tdep.c +++ b/gdb/riscv-fbsd-tdep.c @@ -81,7 +81,7 @@ const struct regset riscv_fbsd_fpregset = regcache_supply_regset, regcache_collect_regset }; -/* Implement the "regset_from_core_section" gdbarch method. */ +/* Implement the "iterate_over_regset_sections" gdbarch method. */ static void riscv_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,