Update comments about removed function
Commit Message
From: Christian Biesinger <cbiesinger@google.com>
regset_from_core_sections doesn't exist anymore; it has been replaced
by the iterate_over_regset_sections gdbarch method. Update comments
accordingly to not confuse readers.
gdb/ChangeLog:
2020-01-23 Christian Biesinger <cbiesinger@google.com>
* aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
Update comment.
* aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
Likewise.
* arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
* gdbcore.h (deprecated_add_core_fns): Update comment to point to
the correct replacement (iterate_over_regset_sections).
* riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
Update comment.
Change-Id: I5eea4d18e15edae5d6dfd5d0d6241e5b2ae40daa
---
gdb/aarch64-fbsd-tdep.c | 2 +-
gdb/aarch64-linux-tdep.c | 2 +-
gdb/arm-fbsd-tdep.c | 2 +-
gdb/gdbcore.h | 3 +--
gdb/riscv-fbsd-tdep.c | 2 +-
5 files changed, 5 insertions(+), 6 deletions(-)
Comments
>>>>> ">" == cbiesinger <cbiesinger@chromium.org> writes:
>> From: Christian Biesinger <cbiesinger@google.com>
>> regset_from_core_sections doesn't exist anymore; it has been replaced
>> by the iterate_over_regset_sections gdbarch method. Update comments
>> accordingly to not confuse readers.
>> gdb/ChangeLog:
>> 2020-01-23 Christian Biesinger <cbiesinger@google.com>
>> * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
>> Update comment.
>> * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
>> Likewise.
>> * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
>> * gdbcore.h (deprecated_add_core_fns): Update comment to point to
>> the correct replacement (iterate_over_regset_sections).
>> * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
>> Update comment.
Thanks. I think this one could be considered obvious, but FAOD it is ok.
Tom
On Thu, Jan 23, 2020 at 11:35 PM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> ">" == cbiesinger <cbiesinger@chromium.org> writes:
>
> >> From: Christian Biesinger <cbiesinger@google.com>
> >> regset_from_core_sections doesn't exist anymore; it has been replaced
> >> by the iterate_over_regset_sections gdbarch method. Update comments
> >> accordingly to not confuse readers.
>
> >> gdb/ChangeLog:
>
> >> 2020-01-23 Christian Biesinger <cbiesinger@google.com>
>
> >> * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
> >> Update comment.
> >> * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
> >> Likewise.
> >> * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
> >> * gdbcore.h (deprecated_add_core_fns): Update comment to point to
> >> the correct replacement (iterate_over_regset_sections).
> >> * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
> >> Update comment.
>
> Thanks. I think this one could be considered obvious, but FAOD it is ok.
Thanks, pushed. Will treat similar patches as obvious in the future.
Christian
@@ -134,7 +134,7 @@ const struct regset aarch64_fbsd_fpregset =
regcache_supply_regset, regcache_collect_regset
};
-/* Implement the "regset_from_core_section" gdbarch method. */
+/* Implement the "iterate_over_regset_sections" gdbarch method. */
static void
aarch64_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,
@@ -582,7 +582,7 @@ aarch64_linux_collect_sve_regset (const struct regset *regset,
size - SVE_HEADER_SIZE);
}
-/* Implement the "regset_from_core_section" gdbarch method. */
+/* Implement the "iterate_over_regset_sections" gdbarch method. */
static void
aarch64_linux_iterate_over_regset_sections (struct gdbarch *gdbarch,
@@ -150,7 +150,7 @@ const struct regset arm_fbsd_vfpregset =
regcache_supply_regset, regcache_collect_regset
};
-/* Implement the "regset_from_core_section" gdbarch method. */
+/* Implement the "iterate_over_regset_sections" gdbarch method. */
static void
arm_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,
@@ -269,8 +269,7 @@ private:
std::string m_storage;
};
-/* NOTE: cagney/2004-04-05: Replaced by "regset.h" and
- regset_from_core_section(). */
+/* Replaced by the "iterate_over_regset_sections" gdbarch method. */
extern void deprecated_add_core_fns (struct core_fns *cf);
extern int default_core_sniffer (struct core_fns *cf, bfd * abfd);
extern int default_check_format (bfd * abfd);
@@ -81,7 +81,7 @@ const struct regset riscv_fbsd_fpregset =
regcache_supply_regset, regcache_collect_regset
};
-/* Implement the "regset_from_core_section" gdbarch method. */
+/* Implement the "iterate_over_regset_sections" gdbarch method. */
static void
riscv_fbsd_iterate_over_regset_sections (struct gdbarch *gdbarch,