From patchwork Sun Jan 12 16:07:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 37333 Received: (qmail 65659 invoked by alias); 12 Jan 2020 16:08:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 65616 invoked by uid 89); 12 Jan 2020 16:08:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_SOFTFAIL autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: barracuda.ebox.ca Received: from barracuda.ebox.ca (HELO barracuda.ebox.ca) (96.127.255.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 12 Jan 2020 16:07:58 +0000 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id GUcTcbeWaNU8CvKK (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 12 Jan 2020 11:07:56 -0500 (EST) Received: from simark.lan (unknown [192.222.164.54]) by smtp.ebox.ca (Postfix) with ESMTP id 0D507441B21; Sun, 12 Jan 2020 11:07:56 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed 2/2] gdbserver: make aarch64_write_goto_address static Date: Sun, 12 Jan 2020 11:07:54 -0500 Message-Id: <20200112160754.290232-2-simon.marchi@polymtl.ca> In-Reply-To: <20200112160754.290232-1-simon.marchi@polymtl.ca> References: <20200112160754.290232-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 X-IsSubscribed: yes This function is only used in this file, so make it static. It fixes this error, when building with -Wmissing-declarations: CXX linux-aarch64-low.o /home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch64-low.c:2642:1: error: no previous declaration for 'void aarch64_write_goto_address(CORE_ADDR, CORE_ADDR, int)' [-Werror=missing-declarations] aarch64_write_goto_address (CORE_ADDR from, CORE_ADDR to, int size) ^~~~~~~~~~~~~~~~~~~~~~~~~~ gdb/gdbserver/ChangeLog: * linux-aarch64-low.c (aarch64_write_goto_address): Make static. --- gdb/gdbserver/ChangeLog | 4 ++++ gdb/gdbserver/linux-aarch64-low.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 40a765a3eded..83be63c393e8 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2020-01-12 Simon Marchi + + * linux-aarch64-low.c (aarch64_write_goto_address): Make static. + 2020-01-12 Simon Marchi * linux-aarch32-tdesc.c: Include linux-aarch32-tdesc.h. diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c index c58347d80ce6..961fd5b3cc41 100644 --- a/gdb/gdbserver/linux-aarch64-low.c +++ b/gdb/gdbserver/linux-aarch64-low.c @@ -2638,7 +2638,7 @@ aarch64_emit_goto (int *offset_p, int *size_p) /* Implementation of emit_ops method "write_goto_address". */ -void +static void aarch64_write_goto_address (CORE_ADDR from, CORE_ADDR to, int size) { uint32_t insn;