From patchwork Sun Jan 12 16:07:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 37332 Received: (qmail 65650 invoked by alias); 12 Jan 2020 16:08:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 65627 invoked by uid 89); 12 Jan 2020 16:08:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_SOFTFAIL autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: barracuda.ebox.ca Received: from barracuda.ebox.ca (HELO barracuda.ebox.ca) (96.127.255.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 12 Jan 2020 16:07:58 +0000 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id 0khjVRamlFTQdFAP (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 12 Jan 2020 11:07:55 -0500 (EST) Received: from simark.lan (unknown [192.222.164.54]) by smtp.ebox.ca (Postfix) with ESMTP id 3A98E441B21; Sun, 12 Jan 2020 11:07:55 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [pushed 1/2] gdbserver: include aarch32/aarch64 header file in corresponding source file Date: Sun, 12 Jan 2020 11:07:53 -0500 Message-Id: <20200112160754.290232-1-simon.marchi@polymtl.ca> MIME-Version: 1.0 X-IsSubscribed: yes When building gdbserver for an aarch64 host with -Wmissing-declarations, I see: CXX linux-aarch32-tdesc.o /home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch32-tdesc.c:28:1: error: no previous declaration for 'const target_desc* aarch32_linux_read_description()' [-Werror=missing-declarations] aarch32_linux_read_description () ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch32-tdesc.c:43:1: error: no previous declaration for 'bool is_aarch32_linux_description(const target_desc*)' [-Werror=missing-declarations] is_aarch32_linux_description (const target_desc *tdesc) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ CXX linux-aarch64-tdesc.o /home/simark/src/binutils-gdb/gdb/gdbserver/linux-aarch64-tdesc.c:32:1: error: no previous declaration for 'const target_desc* aarch64_linux_read_description(uint64_t, bool)' [-Werror=missing-declarations] aarch64_linux_read_description (uint64_t vq, bool pauth_p) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fix it by including linux-aarch32-tdesc.h in linux-aarch32-tdesc.c and linux-aarch64-tdesc.h in linux-aarch64-tdesc.c. gdb/gdbserver/ChangeLog: * linux-aarch32-tdesc.c: Include linux-aarch32-tdesc.h. * linux-aarch64-tdesc.c: Include linux-aarch64-tdesc.h. --- gdb/gdbserver/ChangeLog | 5 +++++ gdb/gdbserver/linux-aarch32-tdesc.c | 3 +++ gdb/gdbserver/linux-aarch64-tdesc.c | 3 +++ 3 files changed, 11 insertions(+) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index b62ed4c02b47..40a765a3eded 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,8 @@ +2020-01-12 Simon Marchi + + * linux-aarch32-tdesc.c: Include linux-aarch32-tdesc.h. + * linux-aarch64-tdesc.c: Include linux-aarch64-tdesc.h. + 2020-01-10 Pedro Alves * fork-child.c (post_fork_inferior): Pass target down to diff --git a/gdb/gdbserver/linux-aarch32-tdesc.c b/gdb/gdbserver/linux-aarch32-tdesc.c index 98d9ac8fd95e..b0dffe27e711 100644 --- a/gdb/gdbserver/linux-aarch32-tdesc.c +++ b/gdb/gdbserver/linux-aarch32-tdesc.c @@ -16,6 +16,9 @@ along with this program. If not, see . */ #include "server.h" + +#include "linux-aarch32-tdesc.h" + #include "tdesc.h" #include "arch/aarch32.h" #include diff --git a/gdb/gdbserver/linux-aarch64-tdesc.c b/gdb/gdbserver/linux-aarch64-tdesc.c index 85fe4143d6ad..897fbb43bd28 100644 --- a/gdb/gdbserver/linux-aarch64-tdesc.c +++ b/gdb/gdbserver/linux-aarch64-tdesc.c @@ -18,6 +18,9 @@ along with this program. If not, see . */ #include "server.h" + +#include "linux-aarch64-tdesc.h" + #include "tdesc.h" #include "arch/aarch64.h" #include "linux-aarch32-low.h"