diff mbox

[v2,7/7] Enable -Wmissing-declarations diagnostic

Message ID 20200110220027.26450-8-simon.marchi@efficios.com
State New
Headers show

Commit Message

Simon Marchi Jan. 10, 2020, 10 p.m. UTC 
Now that most warnings of this kind are fixed, we can enable
-Wmissing-declarations.  I say "most", because it is likely that there
are some more in some configurations I am not able to build, but they
should be pretty easy to fix.

gdb/ChangeLog:

	* warning.m4: Add -Wmissing-declarations to build_warnings.
	* configure: Re-generate.

Change-Id: Iae9b59f22eb5dd1965d09f34c5c9e212cddf67ba
---
 gdb/configure           | 3 ++-
 gdb/gdbserver/configure | 3 ++-
 gdb/warning.m4          | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

Comments

Simon Marchi Jan. 11, 2020, 3:33 a.m. UTC | #1 
On 2020-01-10 5:00 p.m., Simon Marchi wrote:
> Now that most warnings of this kind are fixed, we can enable
> -Wmissing-declarations.  I say "most", because it is likely that there
> are some more in some configurations I am not able to build, but they
> should be pretty easy to fix.
> 
> gdb/ChangeLog:
> 
> 	* warning.m4: Add -Wmissing-declarations to build_warnings.
> 	* configure: Re-generate.

This is missing the ChangeLog entry for gdbserver, I've updated
it locally.

Simon
diff mbox

Patch

diff --git a/gdb/configure b/gdb/configure
index b572d414ca51..aa53c097ca8f 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -16105,7 +16105,8 @@  build_warnings="-Wall -Wpointer-arith \
 -Wshadow=local \
 -Wdeprecated-copy \
 -Wdeprecated-copy-dtor \
--Wredundant-move"
+-Wredundant-move \
+-Wmissing-declarations"
 
 case "${host}" in
   *-*-mingw32*)
diff --git a/gdb/gdbserver/configure b/gdb/gdbserver/configure
index 4de751b44915..f70b3d552156 100755
--- a/gdb/gdbserver/configure
+++ b/gdb/gdbserver/configure
@@ -8094,7 +8094,8 @@  build_warnings="-Wall -Wpointer-arith \
 -Wshadow=local \
 -Wdeprecated-copy \
 -Wdeprecated-copy-dtor \
--Wredundant-move"
+-Wredundant-move \
+-Wmissing-declarations"
 
 case "${host}" in
   *-*-mingw32*)
diff --git a/gdb/warning.m4 b/gdb/warning.m4
index 00bcdfa7ea50..e2b8a43ddbd5 100644
--- a/gdb/warning.m4
+++ b/gdb/warning.m4
@@ -49,7 +49,8 @@  build_warnings="-Wall -Wpointer-arith \
 -Wshadow=local \
 -Wdeprecated-copy \
 -Wdeprecated-copy-dtor \
--Wredundant-move"
+-Wredundant-move \
+-Wmissing-declarations"
 
 case "${host}" in
   *-*-mingw32*)