From patchwork Fri Dec 20 18:31:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 37038 Received: (qmail 123758 invoked by alias); 20 Dec 2019 18:31:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 123737 invoked by uid 89); 20 Dec 2019 18:31:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Dec 2019 18:31:11 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 5A0DB201AD; Fri, 20 Dec 2019 13:31:10 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 850EB20211; Fri, 20 Dec 2019 13:31:07 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 5E0462816F; Fri, 20 Dec 2019 13:31:07 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Fri, 20 Dec 2019 13:31:06 -0500 From: "Sourceware to Gerrit sync (Code Review)" To: Tankut Baris Aktemur , Simon Marchi , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [pushed] Use enum bitfield for the calling_convention attribute of a subroutine X-Gerrit-Change-Id: Ibc6b2f71e885cbc5c3c9d49734f7125acbfd1bcd X-Gerrit-Change-Number: 758 X-Gerrit-ChangeURL: X-Gerrit-Commit: d0922fcf02c6f60ca17cbddccd8b9c8f789eef8c In-Reply-To: References: Reply-To: noreply@gnutoolchain-gerrit.osci.io, tankut.baris.aktemur@intel.com, simon.marchi@polymtl.ca, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Message-Id: <20191220183107.5E0462816F@gnutoolchain-gerrit.osci.io> The original change was created by Tankut Baris Aktemur. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/758 ...................................................................... Use enum bitfield for the calling_convention attribute of a subroutine This is a refactoring. Instead of a plain unsigned value, use an enum bitfield. gdb/ChangeLog: 2019-12-20 Tankut Baris Aktemur * dwarf2read.c (is_valid_DW_AT_calling_convention_for_subroutine): New function. (read_subroutine_type): Validate the parsed DW_AT_calling_convention value before assigning it to a subroutine's calling_convention attribute. * gdbtypes.h (struct func_type) : Use an enum bitfield as its type, instead of plain unsigned. Change-Id: Ibc6b2f71e885cbc5c3c9d49734f7125acbfd1bcd --- M gdb/ChangeLog M gdb/dwarf2read.c M gdb/gdbtypes.h 3 files changed, 42 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c2157e4..d4b17ab 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,15 @@ 2019-12-20 Tankut Baris Aktemur + * dwarf2read.c (is_valid_DW_AT_calling_convention_for_subroutine): + New function. + (read_subroutine_type): Validate the parsed + DW_AT_calling_convention value before assigning it to a + subroutine's calling_convention attribute. + * gdbtypes.h (struct func_type) : Use + an enum bitfield as its type, instead of plain unsigned. + +2019-12-20 Tankut Baris Aktemur + PR gdb/25054 * infcall.c (call_function_by_hand_dummy): Update the argument- passing section for call-by-value parameters. diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 6492889..685d996 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -15872,6 +15872,32 @@ } } +/* Check if the given VALUE is a valid enum dwarf_calling_convention + constant for a subroutine, according to DWARF5 spec, Table 3.3, and + also according to GNU-specific values (see include/dwarf2.h). */ + +static bool +is_valid_DW_AT_calling_convention_for_subroutine (ULONGEST value) +{ + switch (value) + { + case DW_CC_normal: + case DW_CC_program: + case DW_CC_nocall: + return true; + + case DW_CC_GNU_renesas_sh: + case DW_CC_GNU_borland_fastcall_i386: + case DW_CC_GDB_IBM_OpenCL: + return true; + + default: + complaint (_("unrecognized DW_AT_calling_convention value " + "(%lu) for a subroutine"), value); + return false; + } +} + /* Called when we find the DIE that starts a structure or union scope (definition) to create a type for the structure or union. Fill in the type's name and general properties; the members will not be @@ -17540,8 +17566,10 @@ the subroutine die. Otherwise set the calling convention to the default value DW_CC_normal. */ attr = dwarf2_attr (die, DW_AT_calling_convention, cu); - if (attr != nullptr) - TYPE_CALLING_CONVENTION (ftype) = DW_UNSND (attr); + if (attr != nullptr + && is_valid_DW_AT_calling_convention_for_subroutine (DW_UNSND (attr))) + TYPE_CALLING_CONVENTION (ftype) + = (enum dwarf_calling_convention) (DW_UNSND (attr)); else if (cu->producer && strstr (cu->producer, "IBM XL C for OpenCL")) TYPE_CALLING_CONVENTION (ftype) = DW_CC_GDB_IBM_OpenCL; else diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h index 12fa437..167fd80 100644 --- a/gdb/gdbtypes.h +++ b/gdb/gdbtypes.h @@ -1157,9 +1157,9 @@ /* * The calling convention for targets supporting multiple ABIs. Right now this is only fetched from the Dwarf-2 DW_AT_calling_convention attribute. The value is one of the - DW_CC enum dwarf_calling_convention constants. */ + DW_CC constants. */ - unsigned calling_convention : 8; + ENUM_BITFIELD (dwarf_calling_convention) calling_convention : 8; /* * Whether this function normally returns to its caller. It is set from the DW_AT_noreturn attribute if set on the