diff mbox

Add a NEWS entry for multithreaded symbol loading

Message ID 20191220002422.150817-1-cbiesinger@google.com
State New, archived
Headers

Commit Message

Terekhov, Mikhail via Gdb-patches Dec. 20, 2019, 12:24 a.m. UTC 
  Now that we enabled it by default, this change adds a NEWS entry for it.

gdb/ChangeLog:

2019-12-19  Christian Biesinger  <cbiesinger@google.com>

	* NEWS: Mention that multithreaded symbol loading is now on by
	default.

Change-Id: Ic344596a3b1b6e612a0071a50df49588b833c15d
---
 gdb/NEWS | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Eli Zaretskii Dec. 20, 2019, 7:38 a.m. UTC | #1 
> Date: Thu, 19 Dec 2019 18:24:22 -0600
> From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
> Cc: Christian Biesinger <cbiesinger@google.com>
> 
> Now that we enabled it by default, this change adds a NEWS entry for it.
> 
> gdb/ChangeLog:
> 
> 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
> 
> 	* NEWS: Mention that multithreaded symbol loading is now on by
> 	default.

Thanks.

>  *** Changes since GDB 9
>  
> +* Multithreaded symbol loading has now been enabled by default (see entry
> +  for GDB 9, below), providing faster performance for programs with many
> +  symbols.

I think the text should say "on hosts which support that".  Also,
doesn't the manual also say this is disabled by default?
Terekhov, Mikhail via Gdb-patches Dec. 26, 2019, 5:59 a.m. UTC | #2 
On Fri, Dec 20, 2019 at 8:38 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > Date: Thu, 19 Dec 2019 18:24:22 -0600
> > From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
> > Cc: Christian Biesinger <cbiesinger@google.com>
> >
> > Now that we enabled it by default, this change adds a NEWS entry for it.
> >
> > gdb/ChangeLog:
> >
> > 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
> >
> >       * NEWS: Mention that multithreaded symbol loading is now on by
> >       default.
>
> Thanks.
>
> >  *** Changes since GDB 9
> >
> > +* Multithreaded symbol loading has now been enabled by default (see entry
> > +  for GDB 9, below), providing faster performance for programs with many
> > +  symbols.
>
> I think the text should say "on hosts which support that".  Also,
> doesn't the manual also say this is disabled by default?

Will send an updated patch in a moment. But the manual is already
correct; I only changed it on the branch to say that it's disabled by
default.

Christian
diff mbox

Patch

diff --git a/gdb/NEWS b/gdb/NEWS
index ee10914fd8..f4194a0f76 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -3,6 +3,10 @@ 
 
 *** Changes since GDB 9
 
+* Multithreaded symbol loading has now been enabled by default (see entry
+  for GDB 9, below), providing faster performance for programs with many
+  symbols.
+
 *** Changes in GDB 9
 
 * 'thread-exited' event is now available in the annotations interface.