diff mbox

[pushed] Update gdb.base/default.exp for GDB 10

Message ID 20191218214658.8437-1-simon.marchi@efficios.com
State New
Headers show

Commit Message

Simon Marchi Dec. 18, 2019, 9:46 p.m. UTC
Now that the version number in master has been bumped to 10, I get this
failure:

    FAIL: gdb.base/default.exp: show convenience ($_gdb_major = 9 not found)

Update the test accordingly.

gdb/testsuite/ChangeLog:

	* gdb.base/default.exp: Update value of $_gdb_major.
---
 gdb/testsuite/ChangeLog            | 4 ++++
 gdb/testsuite/gdb.base/default.exp | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

Comments

Joel Brobecker Dec. 20, 2019, 5:29 a.m. UTC | #1
> Now that the version number in master has been bumped to 10, I get this
> failure:
> 
>     FAIL: gdb.base/default.exp: show convenience ($_gdb_major = 9 not found)
> 
> Update the test accordingly.

Grumpf. Sorry about that, Simon. I need to update my scripts to deal
with that. I will put that on my list.

> gdb/testsuite/ChangeLog:
> 
> 	* gdb.base/default.exp: Update value of $_gdb_major.
> ---
>  gdb/testsuite/ChangeLog            | 4 ++++
>  gdb/testsuite/gdb.base/default.exp | 2 +-
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
> index 01f6fdf37b2e..1079e71c84c0 100644
> --- a/gdb/testsuite/ChangeLog
> +++ b/gdb/testsuite/ChangeLog
> @@ -1,3 +1,7 @@
> +2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
> +
> +	* gdb.base/default.exp: Update value of $_gdb_major.
> +
>  2019-12-17  Bernd Edlinger  <bernd.edlinger@hotmail.de>
>  
>  	* gdb.base/skip.exp: Fix test failure observed with gcc-9.2.0.
> diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp
> index c323060d9ab9..25e5e661bb58 100644
> --- a/gdb/testsuite/gdb.base/default.exp
> +++ b/gdb/testsuite/gdb.base/default.exp
> @@ -608,7 +608,7 @@ set show_conv_list \
>  	{$_gdb_maint_setting = <internal function _gdb_maint_setting>} \
>  	{$_gdb_setting_str = <internal function _gdb_setting_str>} \
>  	{$_gdb_setting = <internal function _gdb_setting>} \
> -	{$_gdb_major = 9} \
> +	{$_gdb_major = 10} \
>  	{$_gdb_minor = 1} \
>  	{$_shell_exitsignal = void} \
>  	{$_shell_exitcode = 0} \
> -- 
> 2.24.1
Simon Marchi Dec. 20, 2019, 6:15 a.m. UTC | #2
On 2019-12-20 12:29 a.m., Joel Brobecker wrote:
> Grumpf. Sorry about that, Simon. I need to update my scripts to deal
> with that. I will put that on my list.

No problem.  It's nice if you can do it as part of the release process,
but otherwise it's not a big deal for anybody to update it when we
notice it fails, like I did.

Simon
diff mbox

Patch

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 01f6fdf37b2e..1079e71c84c0 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@ 
+2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
+
+	* gdb.base/default.exp: Update value of $_gdb_major.
+
 2019-12-17  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 
 	* gdb.base/skip.exp: Fix test failure observed with gcc-9.2.0.
diff --git a/gdb/testsuite/gdb.base/default.exp b/gdb/testsuite/gdb.base/default.exp
index c323060d9ab9..25e5e661bb58 100644
--- a/gdb/testsuite/gdb.base/default.exp
+++ b/gdb/testsuite/gdb.base/default.exp
@@ -608,7 +608,7 @@  set show_conv_list \
 	{$_gdb_maint_setting = <internal function _gdb_maint_setting>} \
 	{$_gdb_setting_str = <internal function _gdb_setting_str>} \
 	{$_gdb_setting = <internal function _gdb_setting>} \
-	{$_gdb_major = 9} \
+	{$_gdb_major = 10} \
 	{$_gdb_minor = 1} \
 	{$_shell_exitsignal = void} \
 	{$_shell_exitcode = 0} \