[pushed] Remove ARI check for multiple calls to warning or error
Commit Message
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/756
......................................................................
Remove ARI check for multiple calls to warning or error
ARI has a check for multiple calls to warning or error, suggesting
that they be combined into a single call. This triggers at three
places in gdb -- throw_bad_regnum_error, guile_repl_command, and the
end of value_cast -- and after examining these, I think they all make
sense as-is. Instead, it makes sense to remove this check from ARI.
gdb/ChangeLog
2019-12-13 Tom Tromey <tromey@adacore.com>
* contrib/ari/gdb_ari.sh: Remove check for multiple calls to
warning or error.
Change-Id: I0618683623a3c7324460c7b9e5d7f252d88c2e8d
---
M gdb/ChangeLog
M gdb/contrib/ari/gdb_ari.sh
2 files changed, 5 insertions(+), 15 deletions(-)
@@ -1,5 +1,10 @@
2019-12-13 Tom Tromey <tromey@adacore.com>
+ * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
+ warning or error.
+
+2019-12-13 Tom Tromey <tromey@adacore.com>
+
* contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
2019-12-13 Tom Tromey <tromey@adacore.com>
@@ -619,21 +619,6 @@
# General problems
-BEGIN { doc["multiple messages"] = "\
-Do not use multiple calls to warning or error, instead use a single call"
- category["multiple messages"] = ari_gettext
-}
-FNR == 1 {
- warning_fnr = -1
-}
-/(^|[^_[:alnum:]])(warning|error)[[:space:]]*\(/ {
- if (FNR == warning_fnr + 1) {
- fail("multiple messages")
- } else {
- warning_fnr = FNR
- }
-}
-
# Commented out, but left inside sources, just in case.
# BEGIN { doc["inline"] = "\
# Do not use the inline attribute; \