From patchwork Fri Dec 13 22:17:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 36847 Received: (qmail 57710 invoked by alias); 13 Dec 2019 22:17:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 57625 invoked by uid 89); 13 Dec 2019 22:17:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Dec 2019 22:17:21 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 7FC6520456; Fri, 13 Dec 2019 17:17:19 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 8693020A6E; Fri, 13 Dec 2019 17:17:09 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 6C8C220AF6; Fri, 13 Dec 2019 17:17:09 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Fri, 13 Dec 2019 17:17:07 -0500 From: "Sourceware to Gerrit sync (Code Review)" To: Tom Tromey , Pedro Alves , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [pushed] Silence ARI warning about floatformat_to_double X-Gerrit-Change-Id: I778a17a04da417c113194004dd7de3b1df381266 X-Gerrit-Change-Number: 745 X-Gerrit-ChangeURL: X-Gerrit-Commit: c6cbf900d42cf8f2ebbcf33d799c52c54b9aa9f0 In-Reply-To: References: Reply-To: noreply@gnutoolchain-gerrit.osci.io, tromey@sourceware.org, palves@redhat.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Message-Id: <20191213221709.6C8C220AF6@gnutoolchain-gerrit.osci.io> The original change was created by Tom Tromey. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/745 ...................................................................... Silence ARI warning about floatformat_to_double This silences ARI at the one spot that is permitted to call floatformat_to_double, and also removes the corresponding "fix" call from gdb_ari.sh -- it was incorrect, and now is not needed. gdb/ChangeLog 2019-12-13 Tom Tromey * contrib/ari/gdb_ari.sh: Remove "fix" call for floatformat_to_double. * target-float.c (host_float_ops::from_target): Add ARI comment. Change-Id: I778a17a04da417c113194004dd7de3b1df381266 --- M gdb/ChangeLog M gdb/contrib/ari/gdb_ari.sh M gdb/target-float.c 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 44bb65f..d107b6c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2019-12-13 Tom Tromey + * contrib/ari/gdb_ari.sh: Remove "fix" call for + floatformat_to_double. + * target-float.c (host_float_ops::from_target): Add ARI + comment. + +2019-12-13 Tom Tromey + * contrib/ari/gdb_ari.sh: Remove "fix" call for abort. * utils.c (abort_with_message, dump_core, internal_vproblem): Add ARI marker to abort. diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh index 300ed76..9a5b941 100755 --- a/gdb/contrib/ari/gdb_ari.sh +++ b/gdb/contrib/ari/gdb_ari.sh @@ -810,7 +810,6 @@ BEGIN { doc["floatformat_to_double"] = "\ Do not use floatformat_to_double() from libierty, \ instead use floatformat_to_doublest()" - fix("floatformat_to_double", "gdb/doublest.c", 1) category["floatformat_to_double"] = ari_regression } /(^|[^_[:alnum:]])floatformat_to_double[[:space:]]*\(/ { diff --git a/gdb/target-float.c b/gdb/target-float.c index caa6943..ddf20c8 100644 --- a/gdb/target-float.c +++ b/gdb/target-float.c @@ -647,8 +647,8 @@ { double dto; - floatformat_to_double (fmt->split_half ? fmt->split_half : fmt, - from, &dto); + floatformat_to_double /* ARI: floatformat_to_double */ + (fmt->split_half ? fmt->split_half : fmt, from, &dto); *to = (T) dto; return; }