From patchwork Thu Dec 12 02:35:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 36760 Received: (qmail 1265 invoked by alias); 12 Dec 2019 02:35:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 900 invoked by uid 89); 12 Dec 2019 02:35:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1636, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Dec 2019 02:35:15 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 02690203C1; Wed, 11 Dec 2019 21:35:13 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id F05C720A7E for ; Wed, 11 Dec 2019 21:35:05 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id E66E020AF6 for ; Wed, 11 Dec 2019 21:35:05 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Wed, 11 Dec 2019 21:35:02 -0500 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [review v2] Remove a call to update_exec_info X-Gerrit-Change-Id: I63d658561028ac1bc0a0a2b7ac17da1b9c6134fe X-Gerrit-Change-Number: 645 X-Gerrit-ChangeURL: X-Gerrit-Commit: 5864f94dcd285eb706d9c430935e9f7e30fa7fbd In-Reply-To: References: Reply-To: tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Message-Id: <20191212023505.E66E020AF6@gnutoolchain-gerrit.osci.io> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/645 ...................................................................... Remove a call to update_exec_info tui_show_frame_info calls update_exec_info after calling erase_source_content, but there's no need to do this, as erase_source_content already clears the exec info. 2019-12-11 Tom Tromey * tui/tui-stack.c (tui_show_frame_info): Don't call update_exec_info. Change-Id: I63d658561028ac1bc0a0a2b7ac17da1b9c6134fe --- M gdb/ChangeLog M gdb/tui/tui-stack.c 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index fa571fc..57632dc 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-12-11 Tom Tromey + * tui/tui-stack.c (tui_show_frame_info): Don't call + update_exec_info. + +2019-12-11 Tom Tromey + * tui/tui.c (tui_enable): Call tui_display_main. 2019-12-11 Tom Tromey diff --git a/gdb/tui/tui-stack.c b/gdb/tui/tui-stack.c index 4f6fe8e..f42bd83 100644 --- a/gdb/tui/tui-stack.c +++ b/gdb/tui/tui-stack.c @@ -362,10 +362,7 @@ return 0; for (struct tui_source_window_base *win_info : tui_source_windows ()) - { - win_info->erase_source_content (); - win_info->update_exec_info (); - } + win_info->erase_source_content (); return 1; }