From patchwork Wed Dec 4 14:36:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 36506 Received: (qmail 40859 invoked by alias); 4 Dec 2019 14:36:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 40791 invoked by uid 89); 4 Dec 2019 14:36:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Dec 2019 14:36:44 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 0A31020362; Wed, 4 Dec 2019 09:36:42 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 268272068F; Wed, 4 Dec 2019 09:36:36 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id E129228174; Wed, 4 Dec 2019 09:36:35 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Wed, 4 Dec 2019 09:36:34 -0500 From: "Tom Tromey (Code Review)" To: gdb-patches@sourceware.org Cc: Simon Marchi Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [review v2] Propagate endianity to subrange types X-Gerrit-Change-Id: I2998ab919dc28aeff097763c4242f9bfb90823a3 X-Gerrit-Change-Number: 730 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4009f2d7f8fad0f3f28fc878c26bad673002447f In-Reply-To: References: Reply-To: tromey@sourceware.org, simon.marchi@polymtl.ca, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Message-Id: <20191204143635.E129228174@gnutoolchain-gerrit.osci.io> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/730 ...................................................................... Propagate endianity to subrange types A subrange type should inherit its endianity from its base type. gdb/ChangeLog 2019-12-04 Tom Tromey * gdbtypes.c (create_range_type): Inherit endianity from base type. gdb/testsuite/ChangeLog 2019-12-04 Tom Tromey * gdb.ada/scalar_storage/storage.adb: New file. * gdb.ada/scalar_storage/pck.adb: New file. * gdb.ada/scalar_storage/pck.ads: New file. * gdb.ada/scalar_storage.exp: New file. Change-Id: I2998ab919dc28aeff097763c4242f9bfb90823a3 --- M gdb/ChangeLog M gdb/gdbtypes.c M gdb/testsuite/ChangeLog A gdb/testsuite/gdb.ada/scalar_storage.exp A gdb/testsuite/gdb.ada/scalar_storage/pck.adb A gdb/testsuite/gdb.ada/scalar_storage/pck.ads A gdb/testsuite/gdb.ada/scalar_storage/storage.adb 7 files changed, 138 insertions(+), 0 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index d00c2c3..0a7e797 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-12-04 Tom Tromey + * gdbtypes.c (create_range_type): Inherit endianity + from base type. + +2019-12-04 Tom Tromey + * ada-lang.c (decode_constrained_packed_array) (ada_value_assign, value_assign_to_component): Update. * dwarf2loc.c (rw_pieced_value, access_memory) diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index 737ebfe..775e8c1 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -949,6 +949,9 @@ if (high_bound->kind == PROP_CONST && high_bound->data.const_val < 0) TYPE_UNSIGNED (result_type) = 0; + TYPE_ENDIANITY_NOT_DEFAULT (result_type) + = TYPE_ENDIANITY_NOT_DEFAULT (index_type); + return result_type; } diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 1c8aa86..3ba3692 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,12 @@ 2019-12-04 Tom Tromey + * gdb.ada/scalar_storage/storage.adb: New file. + * gdb.ada/scalar_storage/pck.adb: New file. + * gdb.ada/scalar_storage/pck.ads: New file. + * gdb.ada/scalar_storage.exp: New file. + +2019-12-04 Tom Tromey + * gdb.base/endianity.c (struct otherendian) : New field. (main): Initialize it. * gdb.base/endianity.exp: Update. diff --git a/gdb/testsuite/gdb.ada/scalar_storage.exp b/gdb/testsuite/gdb.ada/scalar_storage.exp new file mode 100644 index 0000000..92ad4ed --- /dev/null +++ b/gdb/testsuite/gdb.ada/scalar_storage.exp @@ -0,0 +1,36 @@ +# Copyright 2019 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test that range types with scalar storage order are handled +# properly. + +load_lib "ada.exp" + +standard_ada_testfile storage + +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug ]] != "" } { + return -1 +} + +clean_restart ${testfile} + +set bp_location [gdb_get_line_number "START" ${testdir}/storage.adb] +if ![runto "storage.adb:$bp_location" ] then { + perror "Couldn't run ${testfile}" + return +} + +gdb_test "print V_LE" "= \\(value => 126\\)" +gdb_test "print V_BE" "= \\(value => 126\\)" diff --git a/gdb/testsuite/gdb.ada/scalar_storage/pck.adb b/gdb/testsuite/gdb.ada/scalar_storage/pck.adb new file mode 100644 index 0000000..6535991 --- /dev/null +++ b/gdb/testsuite/gdb.ada/scalar_storage/pck.adb @@ -0,0 +1,21 @@ +-- Copyright 2019 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see . + +package body Pck is + procedure Do_Nothing (A : System.Address) is + begin + null; + end Do_Nothing; +end Pck; diff --git a/gdb/testsuite/gdb.ada/scalar_storage/pck.ads b/gdb/testsuite/gdb.ada/scalar_storage/pck.ads new file mode 100644 index 0000000..b8d0010 --- /dev/null +++ b/gdb/testsuite/gdb.ada/scalar_storage/pck.ads @@ -0,0 +1,19 @@ +-- Copyright 2019 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see . + +with System; +package Pck is + procedure Do_Nothing (A : System.Address); +end Pck; diff --git a/gdb/testsuite/gdb.ada/scalar_storage/storage.adb b/gdb/testsuite/gdb.ada/scalar_storage/storage.adb new file mode 100644 index 0000000..abc1a83 --- /dev/null +++ b/gdb/testsuite/gdb.ada/scalar_storage/storage.adb @@ -0,0 +1,47 @@ +-- Copyright 2019 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see . + +with Pck; use Pck; +with System.Storage_Elements; use System.Storage_Elements; + +procedure Storage is + subtype Some_Range is Natural range 0..127; + + type Rec is record + Value : Some_Range; + end record; + + for Rec use record + Value at 0 range 0..127; + end record; + + type Rec_LE is new Rec; + for Rec_LE'Bit_Order use System.Low_Order_First; + for Rec_LE'Scalar_Storage_Order use System.Low_Order_First; + + type Rec_BE is new Rec; + for Rec_BE'Bit_Order use System.High_Order_First; + for Rec_BE'Scalar_Storage_Order use System.High_Order_First; + + V_LE : Rec_LE; + V_BE : Rec_BE; + +begin + V_LE.Value := 126; + V_BE.Value := 126; + + Do_Nothing (V_LE'Address); -- START + Do_Nothing (V_BE'Address); +end Storage;