From patchwork Tue Nov 26 21:13:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 36263 Received: (qmail 114059 invoked by alias); 26 Nov 2019 21:14:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 113491 invoked by uid 89); 26 Nov 2019 21:14:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Nov 2019 21:14:01 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 0613620413; Tue, 26 Nov 2019 16:14:00 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 963C220D62; Tue, 26 Nov 2019 16:13:12 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 81DA320AF6; Tue, 26 Nov 2019 16:13:12 -0500 (EST) X-Gerrit-PatchSet: 5 Date: Tue, 26 Nov 2019 16:13:07 -0500 From: "Sourceware to Gerrit sync (Code Review)" To: Tom Tromey , Pedro Alves , gdb-patches@sourceware.org Cc: Christian Biesinger Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [pushed] Add maint set/show worker-threads X-Gerrit-Change-Id: I4fb514faa05879d8afe62c77036a4469d57dca2a X-Gerrit-Change-Number: 174 X-Gerrit-ChangeURL: X-Gerrit-Commit: 22138db609721897c213e5a08ccaca206c0fb1f6 In-Reply-To: References: Reply-To: noreply@gnutoolchain-gerrit.osci.io, tromey@sourceware.org, palves@redhat.com, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Message-Id: <20191126211312.81DA320AF6@gnutoolchain-gerrit.osci.io> The original change was created by Tom Tromey. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/174 ...................................................................... Add maint set/show worker-threads This adds maint commands to control the number of worker threads that gdb can use. 2019-11-26 Tom Tromey * NEWS: Add entry. * maint.c (_initialize_maint_cmds): Add "worker-threads" maint commands. Call update_thread_pool_size. (update_thread_pool_size, maintenance_set_worker_threads): New functions. (n_worker_threads): New global. gdb/doc/ChangeLog 2019-11-26 Tom Tromey * gdb.texinfo (Maintenance Commands): Document new maint commands. Change-Id: I4fb514faa05879d8afe62c77036a4469d57dca2a --- M gdb/ChangeLog M gdb/NEWS M gdb/doc/ChangeLog M gdb/doc/gdb.texinfo M gdb/maint.c 5 files changed, 77 insertions(+), 0 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b73ae8d..289cbce 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,12 @@ +2019-11-26 Tom Tromey + + * NEWS: Add entry. + * maint.c (_initialize_maint_cmds): Add "worker-threads" maint + commands. Call update_thread_pool_size. + (update_thread_pool_size, maintenance_set_worker_threads): New + functions. + (n_worker_threads): New global. + 2019-11-26 Christian Biesinger Tom Tromey diff --git a/gdb/NEWS b/gdb/NEWS index 01b38cf..5fd0f41 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -149,6 +149,13 @@ set style highlight intensity VALUE Control the styling of highlightings. +maint set worker-threads +maint show worker-threads + Control the number of worker threads that can be used by GDB. The + default is "unlimited", which lets GDB choose a number that is + reasonable. Currently worker threads are only used when demangling + the names of linker symbols. + maint set test-settings KIND maint show test-settings KIND A set of commands used by the testsuite for exercising the settings diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index c6fa5f5..06d7a6d 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,8 @@ +2019-11-26 Tom Tromey + + * gdb.texinfo (Maintenance Commands): Document new maint + commands. + 2019-11-25 Luis Machado * gdb.texinfo (Debugging Output): Document set debug diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 18bb18b..e3be0cd 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -37876,6 +37876,21 @@ If DWARF frame unwinders are not supported for a particular target architecture, then enabling this flag does not cause them to be used. + +@kindex maint set worker-threads +@kindex maint show worker-threads +@item maint set worker-threads +@item maint show worker-threads +Control the number of worker threads that may be used by @value{GDBN}. +On capable hosts, @value{GDBN} may use multiple threads to speed up +certain CPU-intensive operations, such as demangling symbol names. +While the number of threads used by @value{GDBN} may vary, this +command can be used to set an upper bound on this number. The default +is @code{unlimited}, which lets @value{GDBN} choose a reasonable +number. Note that this only controls worker threads started by +@value{GDBN} itself; libraries used by @value{GDBN} may start threads +of their own. + @kindex maint set profile @kindex maint show profile @cindex profiling GDB diff --git a/gdb/maint.c b/gdb/maint.c index ce59ef6..7ab3fdb 100644 --- a/gdb/maint.c +++ b/gdb/maint.c @@ -46,6 +46,10 @@ #include "cli/cli-setshow.h" #include "cli/cli-cmds.h" +#if CXX_STD_THREAD +#include "gdbsupport/thread-pool.h" +#endif + static void maintenance_do_deprecate (const char *, int); /* Access the maintenance subcommands. */ @@ -840,6 +844,30 @@ error (_("Profiling support is not available on this system.")); } #endif + +static int n_worker_threads = -1; + +/* Update the thread pool for the desired number of threads. */ +static void +update_thread_pool_size () +{ +#if CXX_STD_THREAD + int n_threads = n_worker_threads; + + if (n_threads < 0) + n_threads = std::thread::hardware_concurrency (); + + gdb::thread_pool::g_thread_pool->set_thread_count (n_threads); +#endif +} + +static void +maintenance_set_worker_threads (const char *args, int from_tty, + struct cmd_list_element *c) +{ + update_thread_pool_size (); +} + /* If true, display time usage both at startup and for each command. */ @@ -1313,4 +1341,17 @@ show_maintenance_profile_p, &maintenance_set_cmdlist, &maintenance_show_cmdlist); + + add_setshow_zuinteger_unlimited_cmd ("worker-threads", + class_maintenance, + &n_worker_threads, _("\ +Set the number of worker threads GDB can use."), _("\ +Show the number of worker threads GDB can use."), _("\ +GDB may use multiple threads to speed up certain CPU-intensive operations,\n\ +such as demangling symbol names."), + maintenance_set_worker_threads, NULL, + &maintenance_set_cmdlist, + &maintenance_show_cmdlist); + + update_thread_pool_size (); }