From patchwork Mon Nov 25 05:26:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 36168 Received: (qmail 48215 invoked by alias); 25 Nov 2019 05:27:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 48206 invoked by uid 89); 25 Nov 2019 05:27:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1726, Werror, werror X-HELO: mail.efficios.com Received: from mail.efficios.com (HELO mail.efficios.com) (167.114.142.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Nov 2019 05:27:12 +0000 Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id D0CD33474A8 for ; Mon, 25 Nov 2019 00:27:10 -0500 (EST) Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id c0-vZ8f4temI; Mon, 25 Nov 2019 00:27:10 -0500 (EST) Received: from localhost (ip6-localhost [IPv6:::1]) by mail.efficios.com (Postfix) with ESMTP id 5A5A2347484; Mon, 25 Nov 2019 00:27:10 -0500 (EST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 5A5A2347484 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1574659630; bh=reBgmvK4AcIg6yr5oPi+WIZ8920ZC62UgVmZQG8a9mw=; h=From:To:Date:Message-Id:MIME-Version; b=TJ02y0xKW7r3UQSEU8tromdeFPF+wjOyee+ffXpAZUvZ06xjgyM9LPvXlAim94aBY Yq/XhxbeBcrbqGqlNxlDFykPRVewwuB31I1CX84xtJO1/ovdjUTsy48Yv0BjUpP0oY 8ez5AtryIYlyAhcuE5LbPVaAacDNyYPQtIpuzOdPGJtpoSKKK9fsUyOo9/tOzEdK+v KdCfHKZQ1b0qtN3M3B1wf3YZweU48vY6y7+kO4P/3RYK9VFBHITGeOOH7I1LKR4N1I in38Ub4Tdfa4jssbnLedE/Oipqnn6UPqEF3v2Xrh8xIegr1BDPjdiEv1KDFWz9TzQA ErzJx6OAK8F9A== Received: from mail.efficios.com ([IPv6:::1]) by localhost (mail02.efficios.com [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id sZnrktZwTnfI; Mon, 25 Nov 2019 00:27:10 -0500 (EST) Received: from smarchi-efficios.lan (unknown [192.222.164.54]) by mail.efficios.com (Postfix) with ESMTPSA id 36C2B347474; Mon, 25 Nov 2019 00:27:10 -0500 (EST) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 02/15] Include aarch32-tdep.h in aarch32-tdep.c Date: Mon, 25 Nov 2019 00:26:42 -0500 Message-Id: <20191125052655.22696-3-simon.marchi@efficios.com> In-Reply-To: <20191125052655.22696-1-simon.marchi@efficios.com> References: <20191125052655.22696-1-simon.marchi@efficios.com> MIME-Version: 1.0 The error below shows that aarch32-tdep.c is missing an include for aarch32-tdep.h, add it. CXX aarch32-tdep.o /home/smarchi/src/binutils-gdb/gdb/aarch32-tdep.c: In function ‘const target_desc* aarch32_read_description()’: /home/smarchi/src/binutils-gdb/gdb/aarch32-tdep.c:27:1: error: no previous declaration for ‘const target_desc* aarch32_read_description()’ [-Werror=missing-declarations] aarch32_read_description () ^~~~~~~~~~~~~~~~~~~~~~~~ Putting the include of aarch32-tdep.h early in aarch32-tdep.c gives us an error about target_desc not being defined. Indeed, aarch32-tdep.h uses target_desc without forward-declaring it or including the proper header. Add a forward-declaration for it. gdb/ChangeLog: * aarch32-tdep.c: Include aarch32-tdep.h. * aarch32-tdep.h: Forward-declare struct target_desc. Change-Id: Ica4be4de0fbd7f22d56a29a40fbf0a31b5abdb16 --- gdb/aarch32-tdep.c | 3 +++ gdb/aarch32-tdep.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/gdb/aarch32-tdep.c b/gdb/aarch32-tdep.c index 12d464171ccf..5b082fccf072 100644 --- a/gdb/aarch32-tdep.c +++ b/gdb/aarch32-tdep.c @@ -16,6 +16,9 @@ along with this program. If not, see . */ #include "gdbsupport/common-defs.h" + +#include "aarch32-tdep.h" + #include "gdbsupport/common-regcache.h" #include "arch/aarch32.h" diff --git a/gdb/aarch32-tdep.h b/gdb/aarch32-tdep.h index 7fcea0adb900..eb4c70cd1cee 100644 --- a/gdb/aarch32-tdep.h +++ b/gdb/aarch32-tdep.h @@ -18,6 +18,8 @@ #ifndef AARCH32_TDEP_H #define AARCH32_TDEP_H +struct target_desc; + /* Get the AArch32 target description. */ const target_desc *aarch32_read_description ();