| Message ID | 20191125052655.22696-3-simon.marchi@efficios.com |
|---|---|
| State | New |
| Headers | show |
diff --git a/gdb/aarch32-tdep.c b/gdb/aarch32-tdep.c index 12d464171ccf..5b082fccf072 100644 --- a/gdb/aarch32-tdep.c +++ b/gdb/aarch32-tdep.c @@ -16,6 +16,9 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */ #include "gdbsupport/common-defs.h" + +#include "aarch32-tdep.h" + #include "gdbsupport/common-regcache.h" #include "arch/aarch32.h" diff --git a/gdb/aarch32-tdep.h b/gdb/aarch32-tdep.h index 7fcea0adb900..eb4c70cd1cee 100644 --- a/gdb/aarch32-tdep.h +++ b/gdb/aarch32-tdep.h @@ -18,6 +18,8 @@ #ifndef AARCH32_TDEP_H #define AARCH32_TDEP_H +struct target_desc; + /* Get the AArch32 target description. */ const target_desc *aarch32_read_description ();
The error below shows that aarch32-tdep.c is missing an include for aarch32-tdep.h, add it. CXX aarch32-tdep.o /home/smarchi/src/binutils-gdb/gdb/aarch32-tdep.c: In function ‘const target_desc* aarch32_read_description()’: /home/smarchi/src/binutils-gdb/gdb/aarch32-tdep.c:27:1: error: no previous declaration for ‘const target_desc* aarch32_read_description()’ [-Werror=missing-declarations] aarch32_read_description () ^~~~~~~~~~~~~~~~~~~~~~~~ Putting the include of aarch32-tdep.h early in aarch32-tdep.c gives us an error about target_desc not being defined. Indeed, aarch32-tdep.h uses target_desc without forward-declaring it or including the proper header. Add a forward-declaration for it. gdb/ChangeLog: * aarch32-tdep.c: Include aarch32-tdep.h. * aarch32-tdep.h: Forward-declare struct target_desc. Change-Id: Ica4be4de0fbd7f22d56a29a40fbf0a31b5abdb16 --- gdb/aarch32-tdep.c | 3 +++ gdb/aarch32-tdep.h | 2 ++ 2 files changed, 5 insertions(+)