From patchwork Tue Nov 19 20:36:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 36040 Received: (qmail 33945 invoked by alias); 19 Nov 2019 20:36:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 33921 invoked by uid 89); 19 Nov 2019 20:36:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=boxed, HX-Languages-Length:2033 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Nov 2019 20:36:25 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 78FDA203C1; Tue, 19 Nov 2019 15:36:20 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 8D43E2012A; Tue, 19 Nov 2019 15:36:17 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 6CF6828172; Tue, 19 Nov 2019 15:36:17 -0500 (EST) X-Gerrit-PatchSet: 3 Date: Tue, 19 Nov 2019 15:36:16 -0500 From: "Tom Tromey (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [review v3] Move can_box to tui_gen_win_info X-Gerrit-Change-Id: Idfa58af41341607932d3c39415f6a35ee9b5d3dc X-Gerrit-Change-Number: 512 X-Gerrit-ChangeURL: X-Gerrit-Commit: 9680b159b250c509b906b0009f6657d108122116 In-Reply-To: References: Reply-To: tromey@sourceware.org, andrew.burgess@embecosm.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-79-g83ff7f88f1 Message-Id: <20191119203617.6CF6828172@gnutoolchain-gerrit.osci.io> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/512 ...................................................................... Move can_box to tui_gen_win_info This moves the can_box method to tui_gen_win_info, so that it will be available on the tui_locator_window class. This will be used in a subsequent patch. 2019-11-12 Tom Tromey * tui/tui-data.h (struct tui_gen_win_info) : New method. (struct tui_win_info) : Update. Change-Id: Idfa58af41341607932d3c39415f6a35ee9b5d3dc --- M gdb/ChangeLog M gdb/tui/tui-data.h 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 51ac6b2..131210e 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-11-12 Tom Tromey + * tui/tui-data.h (struct tui_gen_win_info) : New method. + (struct tui_win_info) : Update. + +2019-11-12 Tom Tromey + * tui/tui-stack.h (struct tui_locator_window) : New method. * tui/tui-regs.h (struct tui_data_item_window) : New diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h index d3b84b1..d441a38 100644 --- a/gdb/tui/tui-data.h +++ b/gdb/tui/tui-data.h @@ -85,6 +85,12 @@ /* Compute the maximum height of this window. */ virtual int max_height () const = 0; + /* Return true if this window can be boxed. */ + virtual bool can_box () const + { + return false; + } + /* Resize this window. The parameters are used to set the window's size and position. */ virtual void resize (int height, int width, @@ -203,7 +209,7 @@ return true; } - virtual bool can_box () const + bool can_box () const override { return true; }