From patchwork Thu Nov 14 22:51:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35896 Received: (qmail 98827 invoked by alias); 14 Nov 2019 22:51:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 98750 invoked by uid 89); 14 Nov 2019 22:51:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=tui-data.h, tuidatah, sk:tui_dat, tui-regs.h X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Nov 2019 22:51:26 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 0778A20339; Thu, 14 Nov 2019 17:51:24 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 364AF20393; Thu, 14 Nov 2019 17:51:21 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 134D828171; Thu, 14 Nov 2019 17:51:21 -0500 (EST) X-Gerrit-PatchSet: 2 Date: Thu, 14 Nov 2019 17:51:20 -0500 From: "Tom Tromey (Code Review)" To: Andrew Burgess , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [review v2] Move can_box to tui_gen_win_info X-Gerrit-Change-Id: Idfa58af41341607932d3c39415f6a35ee9b5d3dc X-Gerrit-Change-Number: 512 X-Gerrit-ChangeURL: X-Gerrit-Commit: dbfd01a97a286fdc636e780afee0448832a683df In-Reply-To: References: Reply-To: tromey@sourceware.org, andrew.burgess@embecosm.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Message-Id: <20191114225121.134D828171@gnutoolchain-gerrit.osci.io> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/512 ...................................................................... Move can_box to tui_gen_win_info This moves the can_box method to tui_gen_win_info, so that it will be available on the tui_locator_window class. This will be used in a subsequent patch. gdb/ChangeLog 2019-11-12 Tom Tromey * tui/tui-data.h (struct tui_gen_win_info) : New method. (struct tui_win_info) : Update. Change-Id: Idfa58af41341607932d3c39415f6a35ee9b5d3dc --- M gdb/ChangeLog M gdb/tui/tui-data.h 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 55ee2a8..0bc132b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-11-12 Tom Tromey + * tui/tui-data.h (struct tui_gen_win_info) : New method. + (struct tui_win_info) : Update. + +2019-11-12 Tom Tromey + * tui/tui-stack.h (struct tui_locator_window) : New method. * tui/tui-regs.h (struct tui_data_item_window) : New diff --git a/gdb/tui/tui-data.h b/gdb/tui/tui-data.h index 7464b95..7097a23 100644 --- a/gdb/tui/tui-data.h +++ b/gdb/tui/tui-data.h @@ -85,6 +85,12 @@ /* Compute the maximum height of this window. */ virtual int max_height () const = 0; + /* Return true if this window can be boxed. */ + virtual bool can_box () const + { + return false; + } + /* Resize this window. The parameters are used to set the window's size and position. */ virtual void resize (int height, int width, @@ -203,7 +209,7 @@ return true; } - virtual bool can_box () const + bool can_box () const override { return true; }