From patchwork Mon Nov 11 22:27:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35811 Received: (qmail 2092 invoked by alias); 11 Nov 2019 22:27:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 2084 invoked by uid 89); 11 Nov 2019 22:27:58 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Nov 2019 22:27:57 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 0EBF1204A7; Mon, 11 Nov 2019 17:27:56 -0500 (EST) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 44EA820362; Mon, 11 Nov 2019 17:27:54 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 2232B20AF6; Mon, 11 Nov 2019 17:27:54 -0500 (EST) X-Gerrit-PatchSet: 5 Date: Mon, 11 Nov 2019 17:27:53 -0500 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , Kevin Buettner , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [review v5] Use ctime_r and localtime_r for threadsafety X-Gerrit-Change-Id: I329bbdc39d5b576f51859ba00f1617e024c30cbd X-Gerrit-Change-Number: 475 X-Gerrit-ChangeURL: X-Gerrit-Commit: c8fbde4e4afea0dfb19309b22c1df80a6a5c6a0e In-Reply-To: References: Reply-To: cbiesinger@google.com, cbiesinger@google.com, kevinb@redhat.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-76-gf8b6da0ab5 Message-Id: <20191111222754.2232B20AF6@gnutoolchain-gerrit.osci.io> Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/475 ...................................................................... Use ctime_r and localtime_r for threadsafety To make these calls threadsafe. localtime_r is provided by gnulib if necessary, and for ctime_r we can just use it because it is in a linux- specific file. gdb/ChangeLog: 2019-10-31 Christian Biesinger * maint.c (scoped_command_stats::print_time): Use localtime_r instead of localtime (provided through gnulib if necessary). * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead of ctime. Change-Id: I329bbdc39d5b576f51859ba00f1617e024c30cbd --- M gdb/maint.c M gdb/nat/linux-osdata.c 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gdb/maint.c b/gdb/maint.c index ec9f4ab..a253584 100644 --- a/gdb/maint.c +++ b/gdb/maint.c @@ -1039,10 +1039,11 @@ auto millis = ticks % 1000; std::time_t as_time = system_clock::to_time_t (now); - struct tm *tm = localtime (&as_time); + struct tm tm; + localtime_r (&as_time, &tm); char out[100]; - strftime (out, sizeof (out), "%F %H:%M:%S", tm); + strftime (out, sizeof (out), "%F %H:%M:%S", &tm); printf_unfiltered ("%s.%03d - %s\n", out, (int) millis, msg); } diff --git a/gdb/nat/linux-osdata.c b/gdb/nat/linux-osdata.c index 84357e2..a0b43c6 100644 --- a/gdb/nat/linux-osdata.c +++ b/gdb/nat/linux-osdata.c @@ -913,7 +913,11 @@ { time_t t = (time_t) seconds; - strncpy (time, ctime (&t), maxlen); + /* Per the ctime_r manpage, this buffer needs to be at least 26 + characters long. */ + char buf[30]; + const char *time_str = ctime_r (&t, buf); + strncpy (time, time_str, maxlen); time[maxlen - 1] = '\0'; } }