From patchwork Thu Oct 31 18:29:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35516 Received: (qmail 77933 invoked by alias); 31 Oct 2019 18:29:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 77684 invoked by uid 89); 31 Oct 2019 18:29:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_STOCKGEN autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Oct 2019 18:29:12 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 4F7D12104C; Thu, 31 Oct 2019 14:29:11 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 453CB2031F; Thu, 31 Oct 2019 14:29:07 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 16A3020AF6; Thu, 31 Oct 2019 14:29:07 -0400 (EDT) X-Gerrit-PatchSet: 3 Date: Thu, 31 Oct 2019 14:29:06 -0400 From: "Sourceware to Gerrit sync (Code Review)" To: Christian Biesinger , Luis Machado , Simon Marchi , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [pushed] Convert int to bool in agent.c X-Gerrit-Change-Id: Icb28a65fcc8c7108bcd59287e6be66bf56f8ccb5 X-Gerrit-Change-Number: 462 X-Gerrit-ChangeURL: X-Gerrit-Commit: 75cafaa61a0244016a2c2ee1d0b2742d674d7373 In-Reply-To: References: Reply-To: noreply@gnutoolchain-gerrit.osci.io, simon.marchi@polymtl.ca, luis.machado@linaro.org, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3-75-g9005159e5d Message-Id: <20191031182907.16A3020AF6@gnutoolchain-gerrit.osci.io> The original change was created by Christian Biesinger. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/462 ...................................................................... Convert int to bool in agent.c Also moves an int declaration inside the for loop. Code cleanup, no change in behavior intended. gdb/ChangeLog: 2019-10-31 Christian Biesinger * gdbsupport/agent.c (debug_agent): Change type to bool. (use_agent): Likewise. (all_agent_symbols_look_up): Likewise. (agent_loaded_p): Change return value to bool. (agent_look_up_symbols): Update. (agent_capability_check): Change return value to bool. * gdbsupport/agent.h (agent_loaded_p): Likewise. (debug_agent): Change type to bool. (use_agent): Likewise. (agent_capability_check): Change return value to bool. gdb/gdbserver/ChangeLog: 2019-10-31 Christian Biesinger * ax.h (debug_agent): Remove duplicate declaration. Change-Id: Icb28a65fcc8c7108bcd59287e6be66bf56f8ccb5 --- M gdb/ChangeLog M gdb/gdbserver/ChangeLog M gdb/gdbserver/ax.h M gdb/gdbsupport/agent.c M gdb/gdbsupport/agent.h 5 files changed, 30 insertions(+), 16 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 0382082..ee48133 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,16 @@ +2019-10-31 Christian Biesinger + + * gdbsupport/agent.c (debug_agent): Change type to bool. + (use_agent): Likewise. + (all_agent_symbols_look_up): Likewise. + (agent_loaded_p): Change return value to bool. + (agent_look_up_symbols): Update. + (agent_capability_check): Change return value to bool. + * gdbsupport/agent.h (agent_loaded_p): Likewise. + (debug_agent): Change type to bool. + (use_agent): Likewise. + (agent_capability_check): Change return value to bool. + 2019-10-30 Christian Biesinger * minsyms.c (clear_minimal_symbol_hash_tables): New function. diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index d016549..9606596 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2019-10-31 Christian Biesinger + + * ax.h (debug_agent): Remove duplicate declaration. + 2019-10-26 Tom de Vries * linux-aarch64-low.c: Fix typos in comments. diff --git a/gdb/gdbserver/ax.h b/gdb/gdbserver/ax.h index 3e9fd8f..db8ecae 100644 --- a/gdb/gdbserver/ax.h +++ b/gdb/gdbserver/ax.h @@ -22,7 +22,6 @@ #include "regcache.h" #ifdef IN_PROCESS_AGENT -extern int debug_agent; #define debug_threads debug_agent #endif diff --git a/gdb/gdbsupport/agent.c b/gdb/gdbsupport/agent.c index 02cad46..6d55f58 100644 --- a/gdb/gdbsupport/agent.c +++ b/gdb/gdbsupport/agent.c @@ -26,7 +26,7 @@ #define IPA_SYM_STRUCT_NAME ipa_sym_addresses_common #include "agent.h" -int debug_agent = 0; +bool debug_agent = false; /* A stdarg wrapper for debug_vprintf. */ @@ -45,7 +45,7 @@ #define DEBUG_AGENT debug_agent_printf /* Global flag to determine using agent or not. */ -int use_agent = 0; +bool use_agent = false; /* Addresses of in-process agent's symbols both GDB and GDBserver cares about. */ @@ -73,9 +73,9 @@ static struct ipa_sym_addresses_common ipa_sym_addrs; -static int all_agent_symbols_looked_up = 0; +static bool all_agent_symbols_looked_up = false; -int +bool agent_loaded_p (void) { return all_agent_symbols_looked_up; @@ -87,11 +87,9 @@ int agent_look_up_symbols (void *arg) { - int i; + all_agent_symbols_looked_up = false; - all_agent_symbols_looked_up = 0; - - for (i = 0; i < sizeof (symbol_list) / sizeof (symbol_list[0]); i++) + for (int i = 0; i < sizeof (symbol_list) / sizeof (symbol_list[0]); i++) { CORE_ADDR *addrp = (CORE_ADDR *) ((char *) &ipa_sym_addrs + symbol_list[i].offset); @@ -105,7 +103,7 @@ } } - all_agent_symbols_looked_up = 1; + all_agent_symbols_looked_up = true; return 0; } @@ -260,7 +258,7 @@ /* Return true if agent has capability AGENT_CAP, otherwise return false. */ -int +bool agent_capability_check (enum agent_capa agent_capa) { if (agent_capability == 0) @@ -269,7 +267,7 @@ &agent_capability)) warning (_("Error reading capability of agent")); } - return agent_capability & agent_capa; + return (agent_capability & agent_capa) != 0; } /* Invalidate the cache of agent capability, so we'll read it from inferior diff --git a/gdb/gdbsupport/agent.h b/gdb/gdbsupport/agent.h index 4f05498..27f515d 100644 --- a/gdb/gdbsupport/agent.h +++ b/gdb/gdbsupport/agent.h @@ -42,11 +42,11 @@ thread. */ #define IPA_CMD_BUF_SIZE 1024 -int agent_loaded_p (void); +bool agent_loaded_p (void); -extern int debug_agent; +extern bool debug_agent; -extern int use_agent; +extern bool use_agent; /* Capability of agent. Different agents may have different capabilities, such as installing fast tracepoint or evaluating breakpoint conditions. @@ -61,7 +61,7 @@ AGENT_CAPA_STATIC_TRACE = (0x1 << 1), }; -int agent_capability_check (enum agent_capa); +bool agent_capability_check (enum agent_capa); void agent_capability_invalidate (void);