From patchwork Wed Oct 23 18:50:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35258 Received: (qmail 98861 invoked by alias); 23 Oct 2019 18:50:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 98809 invoked by uid 89); 23 Oct 2019 18:50:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Oct 2019 18:50:22 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id B6C142018B; Wed, 23 Oct 2019 14:50:20 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239]) by mx1.osci.io (Postfix) with ESMTP id 2938620D26; Wed, 23 Oct 2019 14:50:08 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 07E33238BC; Wed, 23 Oct 2019 14:50:08 -0400 (EDT) X-Gerrit-PatchSet: 3 Date: Wed, 23 Oct 2019 14:50:08 -0400 From: "Sourceware to Gerrit sync (Code Review)" To: Tankut Baris Aktemur , gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: merged Subject: [pushed] infcall: remove unused parameter in 'value_arg_coerce' X-Gerrit-Change-Id: If324a1dda3fa5d4c145790b92bd3f656c00296f4 X-Gerrit-Change-Number: 140 X-Gerrit-ChangeURL: X-Gerrit-Commit: 37055cada860277ee53b61bb8fd57293fdfa840b In-Reply-To: References: Reply-To: noreply@gnutoolchain-gerrit.osci.io, tankut.baris.aktemur@intel.com, tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3 Message-Id: <20191023185008.07E33238BC@gnutoolchain-gerrit.osci.io> Sourceware to Gerrit sync has submitted this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/140 ...................................................................... infcall: remove unused parameter in 'value_arg_coerce' Remove the unused SP parameter from the auxiliary function 'value_arg_coerce'. gdb/ChangeLog: 2019-10-23 Tankut Baris Aktemur * infcall.c (value_arg_coerce): Remove an unused parameter. (call_function_by_hand_dummy): Update the call to 'value_arg_coerce'. Change-Id: If324a1dda3fa5d4c145790b92bd3f656c00296f4 --- M gdb/ChangeLog M gdb/infcall.c 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6fafc44..52aea37 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2019-10-23 Tankut Baris Aktemur + * infcall.c (value_arg_coerce): Remove an unused parameter. + (call_function_by_hand_dummy): Update the call to + 'value_arg_coerce'. + +2019-10-23 Tankut Baris Aktemur + * infcall.c (call_function_by_hand_dummy): Refactor. 2019-10-23 Tankut Baris Aktemur diff --git a/gdb/infcall.c b/gdb/infcall.c index 0d8d5b2..b83f1bf 100644 --- a/gdb/infcall.c +++ b/gdb/infcall.c @@ -145,13 +145,11 @@ for arguments to be passed to C, Ada or Fortran functions. If PARAM_TYPE is non-NULL, it is the expected parameter type. - IS_PROTOTYPED is non-zero if the function declaration is prototyped. - SP is the stack pointer were additional data can be pushed (updating - its value as needed). */ + IS_PROTOTYPED is non-zero if the function declaration is prototyped. */ static struct value * value_arg_coerce (struct gdbarch *gdbarch, struct value *arg, - struct type *param_type, int is_prototyped, CORE_ADDR *sp) + struct type *param_type, int is_prototyped) { const struct builtin_type *builtin = builtin_type (gdbarch); struct type *arg_type = check_typedef (value_type (arg)); @@ -984,7 +982,7 @@ param_type = NULL; args[i] = value_arg_coerce (gdbarch, args[i], - param_type, prototyped, &sp); + param_type, prototyped); if (param_type != NULL && language_pass_by_reference (param_type)) args[i] = value_addr (args[i]);