[pushed] Make demangled_name_entry::language not a bitfield
Commit Message
The original change was created by Christian Biesinger.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/221
......................................................................
Make demangled_name_entry::language not a bitfield
Having it as a bitfield causes extra work, and this is not memory-sensitive.
Furthermore, once https://sourceware.org/ml/gdb-patches/2019-10/msg00812.html
lands, the bitfield won't even save any memory at all.
gdb/ChangeLog:
2019-10-22 Christian Biesinger <cbiesinger@google.com>
* symtab.c (struct demangled_name_entry) <language>: Change from
bitfield to regular variable.
Change-Id: I4ea31d1cfcbe0f09a09bd058cd304862308dc388
---
M gdb/ChangeLog
M gdb/symtab.c
2 files changed, 6 insertions(+), 1 deletion(-)
@@ -1,5 +1,10 @@
2019-10-22 Christian Biesinger <cbiesinger@google.com>
+ * symtab.c (struct demangled_name_entry) <language>: Change from
+ bitfield to regular variable.
+
+2019-10-22 Christian Biesinger <cbiesinger@google.com>
+
* symtab.c (struct demangled_name_entry): Add a constructor.
(free_demangled_name_entry): New function to call the destructor
for demangled_name_entry.
@@ -719,7 +719,7 @@
: mangled (mangled_name) {}
gdb::string_view mangled;
- ENUM_BITFIELD(language) language : LANGUAGE_BITS;
+ enum language language;
char demangled[1];
};