From patchwork Wed Oct 16 14:54:04 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35039 Received: (qmail 5773 invoked by alias); 16 Oct 2019 14:54:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 5694 invoked by uid 89); 16 Oct 2019 14:54:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=HX-Languages-Length:2939 X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Oct 2019 14:54:09 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id 26BB820674; Wed, 16 Oct 2019 10:54:08 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 013ED20780; Wed, 16 Oct 2019 10:54:05 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id DF40A20AF7; Wed, 16 Oct 2019 10:54:04 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Wed, 16 Oct 2019 10:54:04 -0400 From: "Sourceware to Gerrit sync (Code Review)" To: Tom de Vries , gdb-patches@sourceware.org Cc: Tom Tromey Auto-Submitted: auto-generated X-Gerrit-MessageType: merged Subject: [review] [gdb/testsuite] Fix regexp for reg value in jit-reader.exp X-Gerrit-Change-Id: Ie494d24fad7a9af7ac6bfaf731c4aa04f1333830 X-Gerrit-Change-Number: 81 X-Gerrit-ChangeURL: X-Gerrit-Commit: b17fcc10396991b4b095c279672398a9c54c03ab In-Reply-To: References: Reply-To: noreply@gnutoolchain-gerrit.osci.io, tdevries@suse.de, tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3 Message-Id: <20191016145404.DF40A20AF7@gnutoolchain-gerrit.osci.io> Sourceware to Gerrit sync has submitted this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/81 ...................................................................... [gdb/testsuite] Fix regexp for reg value in jit-reader.exp On openSUSE Leap 15.1 (as well as on Fedora-x86_64-m64 buildbot) I see: ... FAIL: gdb.base/jit-reader.exp: with jit-reader: after mangling: current frame: info registers ... The problem is that r10 is printed signed: ... r10 0xffffffffffffffb0 -80^M ... but the regexp expects a signed value: ... "r10 $hex +$decimal" \ ... Fix this by allowing signed values. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2019-10-16 Tom de Vries * gdb.base/jit-reader.exp: Allow non-pointer registers to be printed as signed. Change-Id: Ie494d24fad7a9af7ac6bfaf731c4aa04f1333830 --- M gdb/testsuite/ChangeLog M gdb/testsuite/gdb.base/jit-reader.exp 2 files changed, 26 insertions(+), 20 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index ce6e0f2..c9e2457 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2019-10-16 Tom de Vries + + * gdb.base/jit-reader.exp: Allow non-pointer registers to be printed + as signed. + 2019-10-14 Simon Marchi * gdb.mi/list-thread-groups-available.exp: Read entries one by diff --git a/gdb/testsuite/gdb.base/jit-reader.exp b/gdb/testsuite/gdb.base/jit-reader.exp index 7c07c16..1ef3341 100644 --- a/gdb/testsuite/gdb.base/jit-reader.exp +++ b/gdb/testsuite/gdb.base/jit-reader.exp @@ -65,32 +65,33 @@ set any "\[^\r\n\]*" + set neg_decimal "-?$decimal" gdb_test "info registers" \ [multi_line \ - "rax $hex +$decimal" \ - "rbx $hex +$decimal" \ - "rcx $hex +$decimal" \ - "rdx $hex +$decimal" \ - "rsi $hex +$decimal" \ - "rdi $hex +$decimal" \ + "rax $hex +$neg_decimal" \ + "rbx $hex +$neg_decimal" \ + "rcx $hex +$neg_decimal" \ + "rdx $hex +$neg_decimal" \ + "rsi $hex +$neg_decimal" \ + "rdi $hex +$neg_decimal" \ "rbp $hex +$hex" \ "rsp $sp +$sp" \ - "r8 $hex +$decimal" \ - "r9 $hex +$decimal" \ - "r10 $hex +$decimal" \ - "r11 $hex +$decimal" \ - "r12 $hex +$decimal" \ - "r13 $hex +$decimal" \ - "r14 $hex +$decimal" \ - "r15 $hex +$decimal" \ + "r8 $hex +$neg_decimal" \ + "r9 $hex +$neg_decimal" \ + "r10 $hex +$neg_decimal" \ + "r11 $hex +$neg_decimal" \ + "r12 $hex +$neg_decimal" \ + "r13 $hex +$neg_decimal" \ + "r14 $hex +$neg_decimal" \ + "r15 $hex +$neg_decimal" \ "rip $hex +$hex$any" \ "eflags $hex +\\\[$any\\\]" \ - "cs $hex +$decimal" \ - "ss $hex +$decimal" \ - "ds $hex +$decimal" \ - "es $hex +$decimal" \ - "fs $hex +$decimal" \ - "gs $hex +$decimal" \ + "cs $hex +$neg_decimal" \ + "ss $hex +$neg_decimal" \ + "ds $hex +$neg_decimal" \ + "es $hex +$neg_decimal" \ + "fs $hex +$neg_decimal" \ + "gs $hex +$neg_decimal" \ ] }