From patchwork Wed Oct 16 13:08:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Simon Marchi (Code Review)" X-Patchwork-Id: 35036 Received: (qmail 31595 invoked by alias); 16 Oct 2019 13:09:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 31524 invoked by uid 89); 16 Oct 2019 13:09:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy= X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Oct 2019 13:08:59 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id DA0FA20905; Wed, 16 Oct 2019 09:08:57 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 6F533208EF; Wed, 16 Oct 2019 09:08:55 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 53CB020AF7; Wed, 16 Oct 2019 09:08:55 -0400 (EDT) X-Gerrit-PatchSet: 2 Date: Wed, 16 Oct 2019 09:08:54 -0400 From: "Christian Biesinger (Code Review)" To: Christian Biesinger , Sergio Durigan Junior , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: newpatchset Subject: [review] Add a fast_hash function in common-utils X-Gerrit-Change-Id: I77cac0d9aa78fc65316a2af449f52edcae72dc9b X-Gerrit-Change-Number: 38 X-Gerrit-ChangeURL: X-Gerrit-Commit: a3a5025037376ff4723c5a5ebdb4582ced331de0 In-Reply-To: References: Reply-To: cbiesinger@google.com, sergiodj@redhat.com, cbiesinger@google.com, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Gerrit/3.0.3 Message-Id: <20191016130855.53CB020AF7@gnutoolchain-gerrit.osci.io> Christian Biesinger has uploaded a new patch set version (#2). Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/38 ...................................................................... Add a fast_hash function in common-utils Also updates a caller in symtab.c. For now this just calls htab_hash_string but the next patch will change it to xxhash, if available. gdb/ChangeLog: 2019-09-27 Christian Biesinger * utils.c (fast_hash): New function. * utils.h (fast_hash): New function. * symtab.c (hash_demangled_name_entry): Call new function fast_hash. Change-Id: I77cac0d9aa78fc65316a2af449f52edcae72dc9b --- M gdb/symtab.c M gdb/utils.c M gdb/utils.h 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/gdb/symtab.c b/gdb/symtab.c index 0724110..2577f39 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -70,6 +70,7 @@ #include #include "gdbsupport/gdb_string_view.h" #include "gdbsupport/pathstuff.h" +#include "gdbsupport/common-utils.h" /* Forward declarations for local functions. */ @@ -727,7 +728,7 @@ const struct demangled_name_entry *e = (const struct demangled_name_entry *) data; - return iterative_hash (e->mangled.data (), e->mangled.length (), 0); + return fast_hash (e->mangled.data (), e->mangled.length ()); } /* Equality function for the demangled name hash. */ diff --git a/gdb/utils.c b/gdb/utils.c index e685cc2..127ff43 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -3436,6 +3436,14 @@ } } +/* See utils.h. */ + +unsigned int +fast_hash (const char* str, size_t len) +{ + return iterative_hash (str, len, 0); +} + void _initialize_utils (void) { diff --git a/gdb/utils.h b/gdb/utils.h index 76f0da6..83dc57e 100644 --- a/gdb/utils.h +++ b/gdb/utils.h @@ -569,4 +569,10 @@ const gdb_byte *source, ULONGEST source_offset, ULONGEST nbits, int bits_big_endian); +/* A fast hashing function. This can be used to hash strings in a fast way + when the length is known. If no fast hashing library is available, falls + back to iterative_hash from libiberty. */ + +extern unsigned int fast_hash (const char* str, size_t len); + #endif /* UTILS_H */