From patchwork Sat Oct 12 05:05:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Biesinger X-Patchwork-Id: 34927 Received: (qmail 70579 invoked by alias); 12 Oct 2019 05:06:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 70569 invoked by uid 89); 12 Oct 2019 05:06:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit X-HELO: mail-pg1-f194.google.com Received: from mail-pg1-f194.google.com (HELO mail-pg1-f194.google.com) (209.85.215.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Oct 2019 05:06:04 +0000 Received: by mail-pg1-f194.google.com with SMTP id w3so25620pgt.5 for ; Fri, 11 Oct 2019 22:06:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4TixvW1BidIjcYjUmmoXDN1VTu5Q0O/0Dre54uiHMuA=; b=ELuh5duLu9rj8leo79cHeGz5g6q6R0j6so5XMAl0V8UZd+PajujOWcKtHXOs3q8nO8 ahVuFu/GcCoOVj0QOX2rImFtcm9iATv9rNZUHacpWQvBCUCD45eC80cxs50c/OKf9VA9 fXvQ99sWeaSQvD0stAhxfAWxByCgjllYESLI4= Return-Path: Received: from cbiesinger.roam.corp.google.com (70-36-229-82.dedicated.static.sonic.net. [70.36.229.82]) by smtp.googlemail.com with ESMTPSA id k124sm537675pga.83.2019.10.11.22.06.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2019 22:06:01 -0700 (PDT) From: cbiesinger@chromium.org To: gdb-patches@sourceware.org Cc: Christian Biesinger Subject: [PATCH] Remote unnecessary declaration of trace_regblock_size Date: Sat, 12 Oct 2019 00:05:54 -0500 Message-Id: <20191012050554.51250-1-cbiesinger@chromium.org> MIME-Version: 1.0 From: Christian Biesinger This variable is declared in tracepoint.h, which is already included by remote.c. gdb/ChangeLog: 2019-10-10 Christian Biesinger * remote.c (remote_target::get_trace_status): Remove declaration of trace_regblock_size. --- gdb/remote.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gdb/remote.c b/gdb/remote.c index 21160e13acc..73b510dd395 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -13102,14 +13102,13 @@ remote_target::get_trace_status (struct trace_status *ts) { /* Initialize it just to avoid a GCC false warning. */ char *p = NULL; - /* FIXME we need to get register block size some other way. */ - extern int trace_regblock_size; enum packet_result result; struct remote_state *rs = get_remote_state (); if (packet_support (PACKET_qTStatus) == PACKET_DISABLE) return -1; + /* FIXME we need to get register block size some other way. */ trace_regblock_size = rs->get_remote_arch_state (target_gdbarch ())->sizeof_g_packet;