Move declaration of overload_resolution to value.h
Commit Message
The variable is defined in valops.c and has an extern decl in
eval.c; move it to the header file.
gdb/ChangeLog:
2019-09-19 Christian Biesinger <cbiesinger@google.com>
* eval.c: Move declaration of overload_resolution to...
* value.h: ...here.
---
gdb/eval.c | 3 ---
gdb/value.h | 2 ++
2 files changed, 2 insertions(+), 3 deletions(-)
Comments
On 2019-09-19 12:42 a.m., Christian Biesinger via gdb-patches wrote:
> The variable is defined in valops.c and has an extern decl in
> eval.c; move it to the header file.
LGTM, thanks for doing these changes.
Simon
On Thu, Sep 19, 2019 at 8:05 PM Simon Marchi <simark@simark.ca> wrote:
>
> On 2019-09-19 12:42 a.m., Christian Biesinger via gdb-patches wrote:
> > The variable is defined in valops.c and has an extern decl in
> > eval.c; move it to the header file.
>
> LGTM, thanks for doing these changes.
Thanks, pushed.
To ssh://sourceware.org/git/binutils-gdb.git
c7ae7675cf7..e4153ae630f HEAD -> master
Christian
@@ -42,9 +42,6 @@
#include "typeprint.h"
#include <ctype.h>
-/* This is defined in valops.c */
-extern bool overload_resolution;
-
/* Prototypes for local functions. */
static struct value *evaluate_subexp_for_sizeof (struct expression *, int *,
@@ -81,6 +81,8 @@ struct value_print_options;
value_contents_eq for more info.
*/
+extern bool overload_resolution;
+
/* The structure which defines the type of a value. It should never
be possible for a program lval value to survive over a call to the
inferior (i.e. to be put into the history list or an internal