From patchwork Thu Sep 19 04:35:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Terekhov, Mikhail via Gdb-patches" X-Patchwork-Id: 34585 Received: (qmail 121804 invoked by alias); 19 Sep 2019 04:35:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 121785 invoked by uid 89); 19 Sep 2019 04:35:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=arm_apcs_32, H*MI:google X-HELO: mail-yw1-f74.google.com Received: from mail-yw1-f74.google.com (HELO mail-yw1-f74.google.com) (209.85.161.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Sep 2019 04:35:39 +0000 Received: by mail-yw1-f74.google.com with SMTP id k12so1751370ywe.18 for ; Wed, 18 Sep 2019 21:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=+rhW7/x/GQw7LY+bQtc7rd9hklkE9fInS1bSYhTZthE=; b=mzziZK8YH8AIuX1QP9LtlG9y8lbWV4JDIr8aSXqq/tDYxAhd1EUir0KDUGaFq2V3yo DjI6Wj17kh30uNsXHPwhqp3ReoAtatJQUONAmOsurmOg3L2kbu25y7l2gcX2YNvicDKx GO6eZPNw+qR6YFYclWE1dZTK9PE9BlctUqvxnI9+bRUtucYqgskFmzTBd1mvWHogXFgn r/aTqHxqd2bt/sZOsbKt8KWMPdVwXlvMMNnZTcJlG1aLTjiggp0ZBQxYP9tK/AzbvW69 7/gffGlSsndnTkZmBLnZCWbcyW3n70Gx15qUje3XaEN2PfQOnQhkbjfDN6h5gn3oxoQ+ UVhQ== Date: Wed, 18 Sep 2019 23:35:33 -0500 Message-Id: <20190919043533.45876-1-cbiesinger@google.com> Mime-Version: 1.0 Subject: [PATCH] Move arm_apcs_32 extern declaration to header X-Patchwork-Original-From: "Christian Biesinger via gdb-patches" From: "Terekhov, Mikhail via Gdb-patches" Reply-To: Christian Biesinger To: gdb-patches@sourceware.org Cc: Christian Biesinger X-IsSubscribed: yes Instead of having several extern declarations for arm_apcs_32 in a few .c files, declare it in arm-tdep.h. This file is already included from these .c files. gdb/ChangeLog: 2019-09-19 Christian Biesinger * arm-linux-nat.c: Remove extern declaration for arm_apcs_32. * arm-linux-tdep.c: Likewise. * arm-nbsd-nat.c: Likewise. * arm-tdep.h: Declare arm_apcs_32. --- gdb/arm-linux-nat.c | 2 -- gdb/arm-linux-tdep.c | 1 - gdb/arm-nbsd-nat.c | 2 -- gdb/arm-tdep.h | 2 ++ 4 files changed, 2 insertions(+), 5 deletions(-) diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c index ef44e68d319..bef67c7ac7d 100644 --- a/gdb/arm-linux-nat.c +++ b/gdb/arm-linux-nat.c @@ -66,8 +66,6 @@ #define PTRACE_SETHBPREGS 30 #endif -extern bool arm_apcs_32; - class arm_linux_nat_target final : public linux_nat_target { public: diff --git a/gdb/arm-linux-tdep.c b/gdb/arm-linux-tdep.c index 31ea4564dbb..54ea8511cba 100644 --- a/gdb/arm-linux-tdep.c +++ b/gdb/arm-linux-tdep.c @@ -56,7 +56,6 @@ #include "user-regs.h" #include #include "elf/common.h" -extern bool arm_apcs_32; /* Under ARM GNU/Linux the traditional way of performing a breakpoint is to execute a particular software interrupt, rather than use a diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c index 38a9e954b92..5160bfddf50 100644 --- a/gdb/arm-nbsd-nat.c +++ b/gdb/arm-nbsd-nat.c @@ -40,8 +40,6 @@ public: static arm_netbsd_nat_target the_arm_netbsd_nat_target; -extern bool arm_apcs_32; - static void arm_supply_gregset (struct regcache *regcache, struct reg *gregset) { diff --git a/gdb/arm-tdep.h b/gdb/arm-tdep.h index 6d1a91ca35e..e9590e16bab 100644 --- a/gdb/arm-tdep.h +++ b/gdb/arm-tdep.h @@ -26,6 +26,8 @@ struct get_next_pcs; struct arm_get_next_pcs; struct gdb_get_next_pcs; +extern bool arm_apcs_32; + #include "gdbarch.h" #include "arch/arm.h" #include "infrun.h"