diff mbox

Move arm_apcs_32 extern declaration to header

Message ID 20190919043533.45876-1-cbiesinger@google.com
State New, archived
Headers

Commit Message

Terekhov, Mikhail via Gdb-patches Sept. 19, 2019, 4:35 a.m. UTC 
  Instead of having several extern declarations for arm_apcs_32
in a few .c files, declare it in arm-tdep.h. This file is already
included from these .c files.

gdb/ChangeLog:

2019-09-19  Christian Biesinger  <cbiesinger@google.com>

	* arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
	* arm-linux-tdep.c: Likewise.
	* arm-nbsd-nat.c: Likewise.
	* arm-tdep.h: Declare arm_apcs_32.
---
 gdb/arm-linux-nat.c  | 2 --
 gdb/arm-linux-tdep.c | 1 -
 gdb/arm-nbsd-nat.c   | 2 --
 gdb/arm-tdep.h       | 2 ++
 4 files changed, 2 insertions(+), 5 deletions(-)

Comments

Simon Marchi Sept. 19, 2019, 11:04 a.m. UTC | #1 
On 2019-09-19 12:35 a.m., Christian Biesinger via gdb-patches wrote:
> Instead of having several extern declarations for arm_apcs_32
> in a few .c files, declare it in arm-tdep.h. This file is already
> included from these .c files.

LGTM.  If you want, you can also move the documentation of the variable
to the .h and use /* See arm-tdep.h.  */ in the .c.

Simon
Terekhov, Mikhail via Gdb-patches Sept. 20, 2019, 12:18 a.m. UTC | #2 
On Thu, Sep 19, 2019 at 8:04 PM Simon Marchi <simark@simark.ca> wrote:
>
> On 2019-09-19 12:35 a.m., Christian Biesinger via gdb-patches wrote:
> > Instead of having several extern declarations for arm_apcs_32
> > in a few .c files, declare it in arm-tdep.h. This file is already
> > included from these .c files.
>
> LGTM.  If you want, you can also move the documentation of the variable
> to the .h and use /* See arm-tdep.h.  */ in the .c.

Thanks, made that change and pushed.

To ssh://sourceware.org/git/binutils-gdb.git
   e86f08d28f4..c7ae7675cf7  HEAD -> master

Christian
diff mbox

Patch

diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c
index ef44e68d319..bef67c7ac7d 100644
--- a/gdb/arm-linux-nat.c
+++ b/gdb/arm-linux-nat.c
@@ -66,8 +66,6 @@ 
 #define PTRACE_SETHBPREGS 30
 #endif
 
-extern bool arm_apcs_32;
-
 class arm_linux_nat_target final : public linux_nat_target
 {
 public:
diff --git a/gdb/arm-linux-tdep.c b/gdb/arm-linux-tdep.c
index 31ea4564dbb..54ea8511cba 100644
--- a/gdb/arm-linux-tdep.c
+++ b/gdb/arm-linux-tdep.c
@@ -56,7 +56,6 @@ 
 #include "user-regs.h"
 #include <ctype.h>
 #include "elf/common.h"
-extern bool arm_apcs_32;
 
 /* Under ARM GNU/Linux the traditional way of performing a breakpoint
    is to execute a particular software interrupt, rather than use a
diff --git a/gdb/arm-nbsd-nat.c b/gdb/arm-nbsd-nat.c
index 38a9e954b92..5160bfddf50 100644
--- a/gdb/arm-nbsd-nat.c
+++ b/gdb/arm-nbsd-nat.c
@@ -40,8 +40,6 @@  public:
 
 static arm_netbsd_nat_target the_arm_netbsd_nat_target;
 
-extern bool arm_apcs_32;
-
 static void
 arm_supply_gregset (struct regcache *regcache, struct reg *gregset)
 {
diff --git a/gdb/arm-tdep.h b/gdb/arm-tdep.h
index 6d1a91ca35e..e9590e16bab 100644
--- a/gdb/arm-tdep.h
+++ b/gdb/arm-tdep.h
@@ -26,6 +26,8 @@  struct get_next_pcs;
 struct arm_get_next_pcs;
 struct gdb_get_next_pcs;
 
+extern bool arm_apcs_32;
+
 #include "gdbarch.h"
 #include "arch/arm.h"
 #include "infrun.h"