From patchwork Tue Sep 10 19:08:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 34486 Received: (qmail 26522 invoked by alias); 10 Sep 2019 19:09:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 26021 invoked by uid 89); 10 Sep 2019 19:09:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=***********************, 2719 X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.4) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Sep 2019 19:09:08 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 8DC7414782 for ; Tue, 10 Sep 2019 14:09:07 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 7lVji2Nta3Qi07lVjif6rG; Tue, 10 Sep 2019 14:09:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5RQOcVrURgjn5f6HT9C7NkUTHc4tr0OCcFKYqoboFNc=; b=kQOm7oXBXsgYV3senPI5Cgf+oO 6VHASbcdua3ptuPVS2M0v7BrTvUU95czpUDVwiG25/J1OrbjXAROuVaf7U809N3cVmzhRlyNtIXJJ 9trD3L+Sxkb5v6BKMeXXFOxlV; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:51788 helo=bapiya.Home) by box5379.bluehost.com with esmtpa (Exim 4.92) (envelope-from ) id 1i7lVi-000EcZ-U6; Tue, 10 Sep 2019 14:09:07 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 18/20] Remove separator comments from TUI Date: Tue, 10 Sep 2019 13:08:55 -0600 Message-Id: <20190910190857.6562-19-tom@tromey.com> In-Reply-To: <20190910190857.6562-1-tom@tromey.com> References: <20190910190857.6562-1-tom@tromey.com> This removes various separator comments from the TUI. These aren't used elsewhere in gdb, and they were incorrect in some cases as well. gdb/ChangeLog 2019-09-10 Tom Tromey * tui/tui-data.c: Remove separator comments. * tui/tui-layout.c: Remove separator comments. * tui/tui-win.c: Remove separator comments. * tui/tui-wingeneral.c: Remove separator comments. --- gdb/ChangeLog | 7 +++++++ gdb/tui/tui-data.c | 20 -------------------- gdb/tui/tui-layout.c | 11 ----------- gdb/tui/tui-win.c | 15 --------------- gdb/tui/tui-wingeneral.c | 9 --------- 5 files changed, 7 insertions(+), 55 deletions(-) diff --git a/gdb/tui/tui-data.c b/gdb/tui/tui-data.c index c14b1711f60..748d8978218 100644 --- a/gdb/tui/tui-data.c +++ b/gdb/tui/tui-data.c @@ -27,34 +27,19 @@ #include "tui/tui-winsource.h" #include "gdb_curses.h" -/**************************** -** GLOBAL DECLARATIONS -****************************/ struct tui_win_info *tui_win_list[MAX_MAJOR_WINDOWS]; -/*************************** -** Private data -****************************/ static int term_height, term_width; static struct tui_win_info *win_with_focus = NULL; static bool win_resized = false; - -/********************************* -** PUBLIC FUNCTIONS -**********************************/ - int tui_win_is_auxiliary (enum tui_win_type win_type) { return (win_type > MAX_MAJOR_WINDOWS); } -/****************************************** -** ACCESSORS & MUTATORS FOR PRIVATE DATA -******************************************/ - /* Answer a whether the terminal window has been resized or not. */ bool tui_win_resized () @@ -119,11 +104,6 @@ tui_set_term_width_to (int w) } -/***************************** -** OTHER PUBLIC FUNCTIONS -*****************************/ - - /* Answer the next window in the list, cycling back to the top if necessary. */ struct tui_win_info * diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c index 03115a7baa1..0f3e8d945e8 100644 --- a/gdb/tui/tui-layout.c +++ b/gdb/tui/tui-layout.c @@ -40,9 +40,6 @@ #include "tui/tui-source.h" #include "gdb_curses.h" -/******************************* -** Static Local Decls -********************************/ static void show_layout (enum tui_layout_type); static void show_source_or_disasm_and_command (enum tui_layout_type); static void show_source_command (void); @@ -64,9 +61,6 @@ tui_current_layout (void) return current_layout; } -/*************************************** -** DEFINITIONS -***************************************/ /* Show the screen layout defined. */ static void @@ -338,11 +332,6 @@ Layout names are:\n\ } -/************************* -** STATIC LOCAL FUNCTIONS -**************************/ - - /* Function to set the layout to SRC, ASM, SPLIT, NEXT, PREV, DATA, or REGS. */ static void diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c index 8963da2b485..aecb7791f0a 100644 --- a/gdb/tui/tui-win.c +++ b/gdb/tui/tui-win.c @@ -53,9 +53,6 @@ #include -/******************************* -** Static Local Decls -********************************/ static enum tui_status tui_adjust_win_heights (struct tui_win_info *, int); static int new_height_ok (struct tui_win_info *, int); @@ -71,16 +68,9 @@ static void parse_scrolling_args (const char *, int *); -/*************************************** -** DEFINITIONS -***************************************/ #define WIN_HEIGHT_USAGE "Usage: winheight WINDOW-NAME [+ | -] NUM-LINES\n" #define FOCUS_USAGE "Usage: focus [WINDOW-NAME | next | prev]\n" -/*************************************** -** PUBLIC FUNCTIONS -***************************************/ - #ifndef ACS_LRCORNER # define ACS_LRCORNER '+' #endif @@ -720,11 +710,6 @@ tui_initialize_win (void) } -/************************* -** STATIC LOCAL FUNCTIONS -**************************/ - - static void tui_scroll_forward_command (const char *arg, int from_tty) { diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c index 235c17c5fa2..713059d6632 100644 --- a/gdb/tui/tui-wingeneral.c +++ b/gdb/tui/tui-wingeneral.c @@ -28,10 +28,6 @@ #include "gdb_curses.h" -/*********************** -** PUBLIC FUNCTIONS -***********************/ - /* See tui-data.h. */ void @@ -191,8 +187,3 @@ tui_refresh_all () if (locator->is_visible ()) locator->refresh_window (); } - - -/********************************* -** Local Static Functions -*********************************/