From patchwork Thu Aug 22 14:21:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 34243 Received: (qmail 94537 invoked by alias); 22 Aug 2019 14:21:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 94299 invoked by uid 89); 22 Aug 2019 14:21:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1516 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Aug 2019 14:21:55 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 7ECADAF58; Thu, 22 Aug 2019 14:21:52 +0000 (UTC) Date: Thu, 22 Aug 2019 16:21:50 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Cc: Pedro Alves Subject: [PATCH][gdb/testsuite] Make gdb_test message unique in multi-term-settings.exp Message-ID: <20190822142148.GA5361@delia> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes Hi, This racy fail message, reported in PR24929: ... FAIL: gdb.multi/multi-term-settings.exp: inf1_how=attach: inf2_how=attach: \ stop with control-c ... does not make clear which gdb_test fails here: ... if {$expect_ttou} { gdb_test "" "Quit" "stop with control-c" } else { gdb_test "" "received signal SIGINT.*" "stop with control-c" } ... Fix this by making the gdb_test message argument unique. Tested on x86_64-linux. OK for trunk? Thanks, - Tom [gdb/testsuite] Make gdb_test message unique in multi-term-settings.exp gdb/testsuite/ChangeLog: 2019-08-22 Tom de Vries * gdb.multi/multi-term-settings.exp (coretest): Make gdb_test messages unique. --- gdb/testsuite/gdb.multi/multi-term-settings.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.multi/multi-term-settings.exp b/gdb/testsuite/gdb.multi/multi-term-settings.exp index fd3883b692..1c550aaa2e 100644 --- a/gdb/testsuite/gdb.multi/multi-term-settings.exp +++ b/gdb/testsuite/gdb.multi/multi-term-settings.exp @@ -212,9 +212,9 @@ proc coretest {inf1_how inf2_how} { send_gdb "\003" if {$expect_ttou} { - gdb_test "" "Quit" "stop with control-c" + gdb_test "" "Quit" "stop with control-c (Quit)" } else { - gdb_test "" "received signal SIGINT.*" "stop with control-c" + gdb_test "" "received signal SIGINT.*" "stop with control-c (SIGINT)" } # Useful for debugging in case the Ctrl-C above fails.