From patchwork Thu Aug 22 12:13:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 34240 Received: (qmail 125178 invoked by alias); 22 Aug 2019 12:13:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 125168 invoked by uid 89); 22 Aug 2019 12:13:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-23.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=H*MI:andrew, H*m:andrew X-HELO: mail-wm1-f43.google.com Received: from mail-wm1-f43.google.com (HELO mail-wm1-f43.google.com) (209.85.128.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Aug 2019 12:13:48 +0000 Received: by mail-wm1-f43.google.com with SMTP id c5so5338059wmb.5 for ; Thu, 22 Aug 2019 05:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id; bh=jEOBSc2fJJ2NVeCtMMOUDFnbjGVOf605+vKLrkPg9nk=; b=GnpggjV5nndTFktnqR9X/zw/h9n1wG+GDUjy0GSZmLOUvtkocb+L33GQhnTM9a+F1I HnxhO4MeaXOAGONjd0AptsfOMDN10t0KgdJJ/XiZFZKMUTtVIit7asboZVD9sGTwVUwN GpUPQukPu8HPBUj3S6HIpTGkCKAyvrJfyHveofpHZbCxejWDzYUhTcG+9ktNbQJxpgaX rzPcurhfC2o61L3ZMLOrzxlEckPjb7EIxUOpRIymmNgiTl8aBmdw63o/mhZv2ljVKBvl LfsnxPrQXGa4Cl/SMj+gSTTOjgM9vHgkeIUBUuT7txLfpfialZxRzAu5gYkW75Tj0xtm vhDQ== Return-Path: Received: from localhost (host86-128-12-79.range86-128.btcentralplus.com. [86.128.12.79]) by smtp.gmail.com with ESMTPSA id h8sm19086865wrq.49.2019.08.22.05.13.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Aug 2019 05:13:45 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [FYI] gdb/fortran: Remove some dead code from the parser Date: Thu, 22 Aug 2019 13:13:43 +0100 Message-Id: <20190822121343.17365-1-andrew.burgess@embecosm.com> X-IsSubscribed: yes The Fortran parser contains some code that looks like it was probably inherited from the C/C++ parser as it checks to see if the current language is C++, which should never be true when we're in the Fortran parser. gdb/ChangeLog: * f-exp.y (yylex): Remove is_a_field_of_this local variable, and all uses as this was never set to anything but a zero value. --- gdb/ChangeLog | 5 +++++ gdb/f-exp.y | 14 +++----------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/gdb/f-exp.y b/gdb/f-exp.y index 14ea3869bb2..9784ad57d82 100644 --- a/gdb/f-exp.y +++ b/gdb/f-exp.y @@ -1275,7 +1275,6 @@ yylex (void) { std::string tmp = copy_name (yylval.sval); struct block_symbol result; - struct field_of_this_result is_a_field_of_this; enum domain_enum_tag lookup_domains[] = { STRUCT_DOMAIN, @@ -1286,15 +1285,8 @@ yylex (void) for (int i = 0; i < ARRAY_SIZE (lookup_domains); ++i) { - /* Initialize this in case we *don't* use it in this call; that - way we can refer to it unconditionally below. */ - memset (&is_a_field_of_this, 0, sizeof (is_a_field_of_this)); - result = lookup_symbol (tmp.c_str (), pstate->expression_context_block, - lookup_domains[i], - pstate->language ()->la_language - == language_cplus - ? &is_a_field_of_this : NULL); + lookup_domains[i], NULL); if (result.symbol && SYMBOL_CLASS (result.symbol) == LOC_TYPEDEF) { yylval.tsym.type = SYMBOL_TYPE (result.symbol); @@ -1323,14 +1315,14 @@ yylex (void) if (hextype == INT) { yylval.ssym.sym = result; - yylval.ssym.is_a_field_of_this = is_a_field_of_this.type != NULL; + yylval.ssym.is_a_field_of_this = false; return NAME_OR_INT; } } /* Any other kind of symbol */ yylval.ssym.sym = result; - yylval.ssym.is_a_field_of_this = is_a_field_of_this.type != NULL; + yylval.ssym.is_a_field_of_this = false; return NAME; } }