From patchwork Wed Aug 21 02:25:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 34209 Received: (qmail 29709 invoked by alias); 21 Aug 2019 02:25:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 29588 invoked by uid 89); 21 Aug 2019 02:25:48 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.9 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.50.119) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Aug 2019 02:25:44 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 3DEE7117A for ; Tue, 20 Aug 2019 21:25:43 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 0GJjiDf7GdnCe0GJjicpmF; Tue, 20 Aug 2019 21:25:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TAWHFumxb/sIdm2xGFFm2fyws4kerHv46g7pzpAwc4s=; b=lFCWJWDOAjh4UcMxJXUzY1ii1+ Jyfdbrha923xBl5bgo2Urn9y7ettdVG/Vz6UuQoo6asAhk0cD01RzTdIIGpsPtPx4Zil/qaEbsZWP 7eiSxnCL//SzcNzcM0TjBx1tS; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:48672 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i0GJj-001K6n-0V; Tue, 20 Aug 2019 21:25:43 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 12/15] Make tui_locator_window::set_locator_fullname re-render Date: Tue, 20 Aug 2019 20:25:32 -0600 Message-Id: <20190821022535.9762-13-tom@tromey.com> In-Reply-To: <20190821022535.9762-1-tom@tromey.com> References: <20190821022535.9762-1-tom@tromey.com> This changes tui_locator_window::set_locator_fullname to re-render the locator window, so that the callers don't need to do this. gdb/ChangeLog 2019-08-20 Tom Tromey * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call rerender. (tui_update_locator_fullname, tui_show_frame_info): Don't call tui_show_locator_content. --- gdb/ChangeLog | 7 +++++++ gdb/tui/tui-stack.c | 4 +--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gdb/tui/tui-stack.c b/gdb/tui/tui-stack.c index 48062fed712..f6b6bb72b2a 100644 --- a/gdb/tui/tui-stack.c +++ b/gdb/tui/tui-stack.c @@ -284,6 +284,7 @@ tui_locator_window::set_locator_fullname (const char *fullname) locator->full_name[0] = 0; strcat_to_buf (locator->full_name, MAX_LOCATOR_ELEMENT_LEN, fullname); + rerender (); } /* See tui-stack.h. */ @@ -328,7 +329,6 @@ tui_update_locator_fullname (const char *fullname) struct tui_locator_window *locator = tui_locator_win_info_ptr (); locator->set_locator_fullname (fullname); - tui_show_locator_content (); } /* Function to print the frame information for the TUI. The windows are @@ -372,7 +372,6 @@ tui_show_frame_info (struct frame_info *fi) if (!locator_changed_p) return 0; - tui_show_locator_content (); for (struct tui_source_window_base *win_info : tui_source_windows ()) { win_info->maybe_update (fi, sal, locator->line_no, locator->addr); @@ -389,7 +388,6 @@ tui_show_frame_info (struct frame_info *fi) if (!locator_changed_p) return 0; - tui_show_locator_content (); for (struct tui_source_window_base *win_info : tui_source_windows ()) { win_info->erase_source_content ();