From patchwork Tue Aug 6 20:43:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 33984 Received: (qmail 55546 invoked by alias); 6 Aug 2019 20:43:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 55406 invoked by uid 89); 6 Aug 2019 20:43:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.168.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Aug 2019 20:43:44 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 5EDA32DC9A for ; Tue, 6 Aug 2019 15:43:43 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id v6J5hgb1NiQerv6J5h48an; Tue, 06 Aug 2019 15:43:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=poUcnX1+KMwa3DZINq5p3lk2e04LsgjF6Ax+VnGNXIU=; b=x5RvQCd0/ueccicxfogcRlY2+v pwdi6Dg+LBzzSrmVxLTBvLP2A3+MtWg/EcMCJhmYHdhuJXvXY2uCmOA22N5eBWe51KVUN7bfdLUHp KtyEIcaE8GZ2Q2snzNiMlqLuO; Received: from 97-122-178-82.hlrn.qwest.net ([97.122.178.82]:57414 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hv6J5-003V9n-41; Tue, 06 Aug 2019 15:43:43 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 8/8] Require readline 7 or newer Date: Tue, 6 Aug 2019 14:43:34 -0600 Message-Id: <20190806204334.13441-9-tom@tromey.com> In-Reply-To: <20190806204334.13441-1-tom@tromey.com> References: <20190806204334.13441-1-tom@tromey.com> This changes gdb to require readline 7 or newer at build time. 2019-04-21 Tom Tromey * README: Update. * event-top.c: Require readline 7. gdb/doc/ChangeLog 2019-04-21 Tom Tromey * gdb.texinfo (Configure Options): Document minimum version of readline. --- gdb/ChangeLog | 5 +++++ gdb/README | 3 ++- gdb/doc/ChangeLog | 5 +++++ gdb/doc/gdb.texinfo | 3 ++- gdb/event-top.c | 3 +++ 5 files changed, 17 insertions(+), 2 deletions(-) diff --git a/gdb/README b/gdb/README index 8a91aab2a4c..8883a8a09e3 100644 --- a/gdb/README +++ b/gdb/README @@ -439,7 +439,8 @@ more obscure GDB `configure' options are not listed here. `--with-system-readline' Use the readline library installed on the host, rather than the - library supplied as part of GDB. + library supplied as part of GDB. Readline 7 or newer is required; + this is enforced by the build system. `--with-system-zlib Use the zlib library installed on the host, rather than the diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 89b1eda2c17..e384718fc11 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -36897,7 +36897,8 @@ details. @item --with-system-readline Use the readline library installed on the host, rather than the -library supplied as part of @value{GDBN}. +library supplied as part of @value{GDBN}. Readline 7 or newer is +required; this is enforced by the build system. @item --with-system-zlib Use the zlib library installed on the host, rather than the library diff --git a/gdb/event-top.c b/gdb/event-top.c index 2132fb550dc..07cedc42584 100644 --- a/gdb/event-top.c +++ b/gdb/event-top.c @@ -48,6 +48,9 @@ /* readline defines this. */ #undef savestring +/* gdb requires readline 7 now. */ +gdb_static_assert (RL_VERSION_MAJOR >= 7); + static std::string top_level_prompt (); /* Signal handlers. */