[2/4] Make obstack_strdup inline
Commit Message
This changes obstack_strdup to be an inline function. This seems
better to me, considering how small it is; but also it follows what
the code did before the previous patch.
gdb/ChangeLog
2019-08-03 Tom Tromey <tom@tromey.com>
* gdb_obstack.h (obstack_strdup): Define.
* gdb_obstack.c (obstack_strdup): Don't define.
---
gdb/ChangeLog | 5 +++++
gdb/gdb_obstack.c | 10 ----------
gdb/gdb_obstack.h | 6 +++++-
3 files changed, 10 insertions(+), 11 deletions(-)
Comments
On Sat, 3 Aug 2019 20:51:08 -0600
Tom Tromey <tom@tromey.com> wrote:
> This changes obstack_strdup to be an inline function. This seems
> better to me, considering how small it is; but also it follows what
> the code did before the previous patch.
>
> gdb/ChangeLog
> 2019-08-03 Tom Tromey <tom@tromey.com>
>
> * gdb_obstack.h (obstack_strdup): Define.
> * gdb_obstack.c (obstack_strdup): Don't define.
LGTM.
Kevin
@@ -45,13 +45,3 @@ obconcat (struct obstack *obstackp, ...)
return (char *) obstack_finish (obstackp);
}
-
-/* See gdb_obstack.h. */
-
-char *
-obstack_strdup (struct obstack *obstackp, const char *string)
-{
- char *obstring = (char *) obstack_alloc (obstackp, strlen (string) + 1);
- strcpy (obstring, string);
- return obstring;
-}
@@ -89,7 +89,11 @@ extern char *obconcat (struct obstack *obstackp, ...) ATTRIBUTE_SENTINEL;
/* Duplicate STRING, returning an equivalent string that's allocated on the
obstack OBSTACKP. */
-extern char *obstack_strdup (struct obstack *obstackp, const char *string);
+static inline char *
+obstack_strdup (struct obstack *obstackp, const char *string)
+{
+ return (char *) obstack_copy0 (obstackp, string, strlen (string));
+}
/* An obstack that frees itself on scope exit. */
struct auto_obstack : obstack