From patchwork Thu Jul 4 17:02:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 33578 Received: (qmail 111114 invoked by alias); 4 Jul 2019 17:04:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 107110 invoked by uid 89); 4 Jul 2019 17:03:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*RU:esmtpa, H*r:esmtpa X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.251) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Jul 2019 17:03:31 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 7E2B0364A1 for ; Thu, 4 Jul 2019 12:03:30 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id j58shYBcMdnCej58sh6HnY; Thu, 04 Jul 2019 12:03:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jP6nQrMrcRr0hExQHFiwkHf42w0ZVSc8ifxUmX4nux0=; b=d+Ds3rFI7fer1iVwhHSsw+BMFm hC+Y8YYsJLFoXZLeGKH0zkCjDjRKYuEUhvan55dfyKE68fcfaw5KK92rmwyZc/ciax+1jqwnGVK7l bYXJ5IbvLhSIrhSEMmHX53XKl; Received: from 174-29-58-150.hlrn.qwest.net ([174.29.58.150]:34702 helo=bapiya.Home) by box5379.bluehost.com with esmtpa (Exim 4.92) (envelope-from ) id 1hj58s-002sKm-9U; Thu, 04 Jul 2019 12:03:30 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 44/61] Change tui_get_register to return void Date: Thu, 4 Jul 2019 11:02:54 -0600 Message-Id: <20190704170311.15982-45-tom@tromey.com> In-Reply-To: <20190704170311.15982-1-tom@tromey.com> References: <20190704170311.15982-1-tom@tromey.com> tui_get_register returns a tui_status, but nothing checks this, so it can return void instead. 2019-07-04 Tom Tromey * tui/tui-regs.c (tui_get_register): Return void. --- gdb/ChangeLog | 4 ++++ gdb/tui/tui-regs.c | 13 ++++--------- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index 8ba517a6ac0..c6ed19d4295 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -54,9 +54,9 @@ static void tui_show_register_group (tui_data_window *win_info, struct frame_info *frame, int refresh_values_only); -static enum tui_status tui_get_register (struct frame_info *frame, - struct tui_data_item_window *data, - int regnum, bool *changedp); +static void tui_get_register (struct frame_info *frame, + struct tui_data_item_window *data, + int regnum, bool *changedp); @@ -654,13 +654,11 @@ tui_register_format (struct frame_info *frame, int regnum) /* Get the register value from the given frame and format it for the display. When changep is set, check if the new register value has changed with respect to the previous call. */ -static enum tui_status +static void tui_get_register (struct frame_info *frame, struct tui_data_item_window *data, int regnum, bool *changedp) { - enum tui_status ret = TUI_FAILURE; - if (changedp) *changedp = false; if (target_has_registers) @@ -674,8 +672,5 @@ tui_get_register (struct frame_info *frame, *changedp = true; xfree (prev_content); - - ret = TUI_SUCCESS; } - return ret; }