From patchwork Thu Jul 4 17:02:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 33577 Received: (qmail 110539 invoked by alias); 4 Jul 2019 17:04:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 107090 invoked by uid 89); 4 Jul 2019 17:03:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-19.0 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*RU:esmtpa, H*r:esmtpa X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (192.185.196.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Jul 2019 17:03:31 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 2850C645E for ; Thu, 4 Jul 2019 12:03:30 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id j58shuwah2PzOj58sh7dRs; Thu, 04 Jul 2019 12:03:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rg9nYsssqHPgcVB1HoBC0VlgFyCb4ntKauxCkVwbImA=; b=XOW0A1IwCYYCDxD8GB8aqNKhV1 6A9SnJ+cPn003nUbhpTuz6ODp9RWnXky+mMFnpwpfyIXe3ONwM4tthTCyJAxbBdk0+UHplkS7lco5 t6VlUqiPqB8uSOF8NxYvVNTJc; Received: from 174-29-58-150.hlrn.qwest.net ([174.29.58.150]:34702 helo=bapiya.Home) by box5379.bluehost.com with esmtpa (Exim 4.92) (envelope-from ) id 1hj58r-002sKm-SS; Thu, 04 Jul 2019 12:03:30 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 43/61] Simplify tui_gen_win_info::make_visible Date: Thu, 4 Jul 2019 11:02:53 -0600 Message-Id: <20190704170311.15982-44-tom@tromey.com> In-Reply-To: <20190704170311.15982-1-tom@tromey.com> References: <20190704170311.15982-1-tom@tromey.com> I noticed that tui_gen_win_info::make_visible was much wordier than it needed to be. This simplifies it. 2019-07-04 Tom Tromey * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Simplify. --- gdb/ChangeLog | 5 +++++ gdb/tui/tui-wingeneral.c | 19 +++++++------------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c index 3dca621b887..4e6637e8687 100644 --- a/gdb/tui/tui-wingeneral.c +++ b/gdb/tui/tui-wingeneral.c @@ -165,20 +165,15 @@ tui_make_window (struct tui_gen_win_info *win_info, enum tui_box box_it) void tui_gen_win_info::make_visible (bool visible) { + if (is_visible == visible) + return; + is_visible = visible; + if (visible) + tui_make_window (this, (tui_win_is_auxiliary (type) + ? DONT_BOX_WINDOW : BOX_WINDOW)); + else { - if (!is_visible) - { - tui_make_window (this, (tui_win_is_auxiliary (type) - ? DONT_BOX_WINDOW : BOX_WINDOW)); - is_visible = true; - } - } - else if (!visible - && is_visible - && handle != NULL) - { - is_visible = false; tui_delete_win (handle); handle = NULL; }