From patchwork Thu Jul 4 17:02:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 33550 Received: (qmail 106362 invoked by alias); 4 Jul 2019 17:03:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 105288 invoked by uid 89); 4 Jul 2019 17:03:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=H*RU:esmtpa, H*r:esmtpa, HX-Spam-Relays-External:esmtpa X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.216) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 04 Jul 2019 17:03:21 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 95A0A91542D for ; Thu, 4 Jul 2019 12:03:20 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id j58ihuwRr2PzOj58ih7dJ9; Thu, 04 Jul 2019 12:03:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VAqjzZNNCEJ7XH/HMzp2tW0SvSp42c62DRsg8WOL0CQ=; b=HVPq4nNH/CwioD2VFF+wjrR8Rn pSuHL3x8Hv24vtSZJXftkgrm/b0EfPePQuJrQPXWi0GOwf4ZxEkbCZmz59jcKrf8Msn4deaWDQhrB nSP9GhIeb2UxOsxvXtEAI+bDe; Received: from 174-29-58-150.hlrn.qwest.net ([174.29.58.150]:34692 helo=bapiya.Home) by box5379.bluehost.com with esmtpa (Exim 4.92) (envelope-from ) id 1hj58i-002sDI-CJ; Thu, 04 Jul 2019 12:03:20 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 18/61] Simplify tui_show_registers Date: Thu, 4 Jul 2019 11:02:28 -0600 Message-Id: <20190704170311.15982-19-tom@tromey.com> In-Reply-To: <20190704170311.15982-1-tom@tromey.com> References: <20190704170311.15982-1-tom@tromey.com> tui_show_registers keeps a local status variable, but it is not actually needed. This rearranges the function to remove the variable. 2019-07-04 Tom Tromey * tui/tui-regs.c (tui_show_registers): Simplify. --- gdb/ChangeLog | 4 ++++ gdb/tui/tui-regs.c | 17 ++++++----------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c index f99e7c12f7f..931787ae4b5 100644 --- a/gdb/tui/tui-regs.c +++ b/gdb/tui/tui-regs.c @@ -121,8 +121,6 @@ tui_data_window::first_reg_element_no_inline (int line_no) const void tui_show_registers (struct reggroup *group) { - enum tui_status ret = TUI_FAILURE; - /* Make sure the curses mode is enabled. */ tui_enable (); @@ -142,15 +140,7 @@ tui_show_registers (struct reggroup *group) { tui_show_register_group (TUI_DATA_WIN, group, get_selected_frame (NULL), group == TUI_DATA_WIN->current_group); - ret = TUI_SUCCESS; - } - if (ret == TUI_FAILURE) - { - TUI_DATA_WIN->current_group = 0; - TUI_DATA_WIN->erase_data_content (NO_REGS_STRING); - } - else - { + /* Clear all notation of changed values. */ for (auto &&data_item_win : TUI_DATA_WIN->regs_content) { @@ -160,6 +150,11 @@ tui_show_registers (struct reggroup *group) TUI_DATA_WIN->current_group = group; TUI_DATA_WIN->display_all_data (); } + else + { + TUI_DATA_WIN->current_group = 0; + TUI_DATA_WIN->erase_data_content (NO_REGS_STRING); + } }