From patchwork Sun Jun 23 22:42:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 33308 Received: (qmail 51012 invoked by alias); 23 Jun 2019 22:44:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 49120 invoked by uid 89); 23 Jun 2019 22:43:54 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 23 Jun 2019 22:43:47 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id CA7AC7A3E for ; Sun, 23 Jun 2019 17:43:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id fBD7hwgm3dnCefBD7hWq3W; Sun, 23 Jun 2019 17:43:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=L/LaQqlWs56Z3oPQKNJXg/tpv86csVFbU7P+Qaqlmdo=; b=NUV4xBGsKkz9Iwgy7rlHFhkCae 0v1pZ4Bi3MIeI1M7xMix4CO/Uw/RxmBY0RfOV/ZG6epkVlr3TSquEMssVvHlKsXDbwrR3M1P+hs+L kZP3dMt6MZuI591cj9xqZJJhR; Received: from 75-166-12-78.hlrn.qwest.net ([75.166.12.78]:54396 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hfBD7-000vDQ-Jz; Sun, 23 Jun 2019 17:43:45 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 28/66] Remove redundant check from make_visible Date: Sun, 23 Jun 2019 16:42:51 -0600 Message-Id: <20190623224329.16060-29-tom@tromey.com> In-Reply-To: <20190623224329.16060-1-tom@tromey.com> References: <20190623224329.16060-1-tom@tromey.com> This removes a check of the window type from make_visible. This function already checks that the window type is not CMD_WIN near the top, so this condition can never be false. gdb/ChangeLog 2019-06-23 Tom Tromey * tui/tui-wingeneral.c (make_visible): Remove check of window type. --- gdb/ChangeLog | 5 +++++ gdb/tui/tui-wingeneral.c | 4 +--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c index 4d168af0c09..73d77ce19f3 100644 --- a/gdb/tui/tui-wingeneral.c +++ b/gdb/tui/tui-wingeneral.c @@ -181,9 +181,7 @@ make_visible (struct tui_gen_win_info *win_info, bool visible) { if (!win_info->is_visible) { - tui_make_window (win_info, - (win_info->type != CMD_WIN - && !tui_win_is_auxillary (win_info->type))); + tui_make_window (win_info, !tui_win_is_auxillary (win_info->type)); win_info->is_visible = true; } }