From patchwork Sun Jun 16 16:01:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 33150 Received: (qmail 3512 invoked by alias); 16 Jun 2019 16:01:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 3504 invoked by uid 89); 16 Jun 2019 16:01:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, RCVD_IN_SEMBLACK, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=sk:add_sym, sk:SYMBOL_, type_name, internalvar X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.100) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Jun 2019 16:01:51 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 69A3A570C for ; Sun, 16 Jun 2019 11:01:49 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cXbJh7i8BdnCecXbJhjD6d; Sun, 16 Jun 2019 11:01:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version :Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=23GwFhYN5RScQNQnFH+yJECUM4UGXZjELOrfHP+fbb0=; b=wMiB1disDpDK3c4PKJ/+yTCWuI LAmvwUhLWS5WYJ+A50tYInJCsr10PFmCGmimc7+iJb6JEeNLeC0EAGawhh+r2nyJ8iWGfwssueZTJ vSOBvTmaR9kA4lLJOAvDerTde; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:36926 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hcXbJ-004F7B-7Q; Sun, 16 Jun 2019 11:01:49 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [FYI] Replace uses of concat with xstrdup Date: Sun, 16 Jun 2019 10:01:47 -0600 Message-Id: <20190616160147.24203-1-tom@tromey.com> I noticed a couple of spots using concat that could use xstrdup instead. This patch fixes these. gdb/ChangeLog 2019-06-16 Tom Tromey * coffread.c (process_coff_symbol): Use xstrdup. * value.c (create_internalvar): Use xstrdup. --- gdb/ChangeLog | 5 +++++ gdb/coffread.c | 2 +- gdb/value.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/coffread.c b/gdb/coffread.c index 8b31200545d..0c7c4b58b6f 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -1728,7 +1728,7 @@ process_coff_symbol (struct coff_symbol *cs, && *SYMBOL_LINKAGE_NAME (sym) != '~' && *SYMBOL_LINKAGE_NAME (sym) != '.') TYPE_NAME (SYMBOL_TYPE (sym)) = - concat (SYMBOL_LINKAGE_NAME (sym), (char *)NULL); + xstrdup (SYMBOL_LINKAGE_NAME (sym)); add_symbol_to_list (sym, get_file_symbols ()); break; diff --git a/gdb/value.c b/gdb/value.c index 71030efed07..1b22cf916e3 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -2025,7 +2025,7 @@ create_internalvar (const char *name) { struct internalvar *var = XNEW (struct internalvar); - var->name = concat (name, (char *)NULL); + var->name = xstrdup (name); var->kind = INTERNALVAR_VOID; var->next = internalvars; internalvars = var;