[FYI] Recognize _ in attribute names
Commit Message
Ada attribute names can contain "_", but the lexer currently does not
allow this -- even though the "attributes" array lists some attributes
spelled this way.
This patch fixes the bug and adds test cases for the existing
attributes.
This was reviewed off-list by Joel. I'm checking it in.
gdb/ChangeLog
2019-06-14 Tom Tromey <tromey@adacore.com>
* ada-lex.l: Allow "_" in attribute names.
gdb/testsuite/ChangeLog
2019-06-14 Tom Tromey <tromey@adacore.com>
* gdb.ada/formatted_ref.exp (test_p_x_addr): Check
'unchecked_access and 'unrestricted_access as well.
---
gdb/ChangeLog | 4 ++++
gdb/ada-lex.l | 2 +-
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.ada/formatted_ref.exp | 18 ++++++++++--------
4 files changed, 20 insertions(+), 9 deletions(-)
@@ -216,7 +216,7 @@ false { return FALSEKEYWORD; }
/* ATTRIBUTES */
-{TICK}[a-zA-Z][a-zA-Z]+ { BEGIN INITIAL; return processAttribute (yytext+1); }
+{TICK}[a-zA-Z][a-zA-Z_]+ { BEGIN INITIAL; return processAttribute (yytext+1); }
/* PUNCTUATION */
@@ -67,14 +67,16 @@ proc test_p_x { var val addr } {
proc test_p_x_addr { var addr } {
global gdb_prompt
- set test "print/x $var'access"
- gdb_test_multiple $test $test {
- -re "\\$\[0-9\]+ = $addr.*$gdb_prompt $" {
- pass $test
- }
- -re "\\$\[0-9\]+ = 0x\[a-f0-9+\]+.*$gdb_prompt $" {
- fail "$test (prints unexpected address)"
- }
+ foreach attr {access unchecked_access unrestricted_access} {
+ set test "print/x $var'$attr"
+ gdb_test_multiple $test $test {
+ -re "\\$\[0-9\]+ = $addr.*$gdb_prompt $" {
+ pass $test
+ }
+ -re "\\$\[0-9\]+ = 0x\[a-f0-9+\]+.*$gdb_prompt $" {
+ fail "$test (prints unexpected address)"
+ }
+ }
}
return 0
}