From patchwork Tue May 21 09:43:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Hayward X-Patchwork-Id: 32780 Received: (qmail 18200 invoked by alias); 21 May 2019 09:43:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 18191 invoked by uid 89); 21 May 2019 09:43:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, MIME_BASE64_BLANKS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.1 spammy=send_gdb, gdb_file_cmd, 18644 X-HELO: EUR02-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr20042.outbound.protection.outlook.com (HELO EUR02-VE1-obe.outbound.protection.outlook.com) (40.107.2.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 May 2019 09:43:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F8YZOcoeqOYJGNgSzyMEw8VRfRmvzY9YAlKAgUWaqXM=; b=BOYOrwTc4+5MS/4WGfkRWlgU8X5AWzBat0gd8lq8ZA9yGTACG+bEMy34jn5p2StXkxZQZqkqvlOE5a9C19gXQwLpPEZ/vNclvWQmbJc7VDOaaB2FnuUmvyW6VpilCxGAv0mEK8WomMfeH1sBq1eJfiIiYrtYfi1wD/sGG/kuvFo= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2135.eurprd08.prod.outlook.com (10.172.226.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1900.16; Tue, 21 May 2019 09:43:25 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::8c26:bb4b:6c93:9d40%2]) with mapi id 15.20.1900.020; Tue, 21 May 2019 09:43:25 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd , Alan Hayward Subject: [PUSHED/OBV] testsuite: Mark the kill in gdbserver_run as optional Date: Tue, 21 May 2019 09:43:25 +0000 Message-ID: <20190521094322.62995-1-alan.hayward@arm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-oob-tlc-oobclassifiers: OLM:8273; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes This matches the kill in gdb_file_cmd, and ensures that the command is not sent to the gdb.in file. When gdb.in is used as a batch file, any kill commands run before the target is started will cause gdb to stop processing commands. gdb/testsuite/ChangeLog: * lib/gdbserver-support.exp (gdbserver_run): Mark kill as optional. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/lib/gdbserver-support.exp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) -- 2.20.1 (Apple Git-117) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 5cfad2754e..176b7f74be 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2019-05-21 Alan Hayward + + * lib/gdbserver-support.exp (gdbserver_run): Mark kill as optional. + 2019-05-18 Andrew Burgess PR gdb/18644 diff --git a/gdb/testsuite/lib/gdbserver-support.exp b/gdb/testsuite/lib/gdbserver-support.exp index 2ccc717ef6..ade99c0ea1 100644 --- a/gdb/testsuite/lib/gdbserver-support.exp +++ b/gdb/testsuite/lib/gdbserver-support.exp @@ -484,7 +484,7 @@ proc gdbserver_run { child_args } { # Kill anything running before we try to start gdbserver, in case # we are sharing a serial connection. global gdb_prompt - send_gdb "kill\n" + send_gdb "kill\n" optional gdb_expect 120 { -re "Kill the program being debugged. .y or n. $" { send_gdb "y\n"