From patchwork Thu May 9 23:24:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Baldwin X-Patchwork-Id: 32629 Received: (qmail 45137 invoked by alias); 9 May 2019 23:25:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 45128 invoked by uid 89); 9 May 2019 23:25:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS, SPF_SOFTFAIL autolearn=ham version=3.3.1 spammy=HX-Greylist:succeeded, HX-Greylist:SMTP, HX-Greylist:AUTH, HX-Languages-Length:1208 X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 May 2019 23:25:22 +0000 Received: from ralph.com (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 5B28E10AFCD for ; Thu, 9 May 2019 19:25:20 -0400 (EDT) From: John Baldwin To: gdb-patches@sourceware.org Subject: [PATCH] Return TARGET_XFER_EOF if reading at the end of TARGET_OBJECT_SIGNAL_INFO. Date: Thu, 9 May 2019 16:24:25 -0700 Message-Id: <20190509232425.2243-1-jhb@FreeBSD.org> MIME-Version: 1.0 X-IsSubscribed: yes This fixes an assertion failure if a request is made to read just past the end of a native thread's signal information structure. gdb/ChangeLog: * fbsd-nat.c (fbsd_nat_target::xfer_partial) [USE_SIGINFO]: Return TARGET_XFER_EOF if len is zero. --- gdb/ChangeLog | 5 +++++ gdb/fbsd-nat.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5b0a9fde61..de24a26a59 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-05-09 John Baldwin + + * fbsd-nat.c (fbsd_nat_target::xfer_partial) [USE_SIGINFO]: Return + TARGET_XFER_EOF if len is zero. + 2019-05-08 Tom Tromey * gdbtypes.c (objfile_type_data): Change type. diff --git a/gdb/fbsd-nat.c b/gdb/fbsd-nat.c index d4f4c8cf35..35188b44fa 100644 --- a/gdb/fbsd-nat.c +++ b/gdb/fbsd-nat.c @@ -720,7 +720,7 @@ fbsd_nat_target::xfer_partial (enum target_object object, memcpy (readbuf, ((gdb_byte *) &pl.pl_siginfo) + offset, len); *xfered_len = len; - return TARGET_XFER_OK; + return len == 0 ? TARGET_XFER_EOF : TARGET_XFER_OK; } #endif #ifdef KERN_PROC_AUXV