From patchwork Sat May 4 20:11:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 32550 Received: (qmail 94153 invoked by alias); 4 May 2019 20:11:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 94135 invoked by uid 89); 4 May 2019 20:11:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.2 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1002 X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.194.2) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 04 May 2019 20:11:51 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 87D40400C566D for ; Sat, 4 May 2019 14:30:49 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id N10gh5mQb2PzON10ghYl5w; Sat, 04 May 2019 15:11:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SRTd/OYrgC1Z5kwNhwlcglLg3X9ixhNTxnGBr4/NdRQ=; b=tsQcw3ImUz8Q8xUFw6n7B8ap3e Q0rTNmV/o+T61BryvMEu//jafP/5elSJwO920rjlVpwnrFJ5xXh+LMkBDArXdfbaD11330vnXJuVW 1JS7zwBGDYBMBukeZxoRrv+I/; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:39978 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hN10g-004Jf3-DC; Sat, 04 May 2019 15:11:50 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [FYI 5/7] Use "false" in compile_cplus_convert_enum Date: Sat, 4 May 2019 14:11:45 -0600 Message-Id: <20190504201147.3095-6-tom@tromey.com> In-Reply-To: <20190504201147.3095-1-tom@tromey.com> References: <20190504201147.3095-1-tom@tromey.com> This changes compile_cplus_convert_enum to use "false". Note that this variable is never modified, which seems like an error. I filed PR compile/24473 for this. gdb/ChangeLog 2019-05-04 Tom Tromey * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use "false". --- gdb/ChangeLog | 5 +++++ gdb/compile/compile-cplus-types.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/compile/compile-cplus-types.c b/gdb/compile/compile-cplus-types.c index ee3bb438a3b..692393085e2 100644 --- a/gdb/compile/compile-cplus-types.c +++ b/gdb/compile/compile-cplus-types.c @@ -910,7 +910,7 @@ static gcc_type compile_cplus_convert_enum (compile_cplus_instance *instance, struct type *type, enum gcc_cp_symbol_kind nested_access) { - int scoped_enum_p = FALSE; + bool scoped_enum_p = false; /* Create a new scope for this type. */ compile_scope scope = instance->new_scope (TYPE_NAME (type), type);