From patchwork Sat May 4 20:11:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 32553 Received: (qmail 94225 invoked by alias); 4 May 2019 20:11:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 94134 invoked by uid 89); 4 May 2019 20:11:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.62.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 04 May 2019 20:11:51 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway20.websitewelcome.com (Postfix) with ESMTP id ABC54400C6CB0 for ; Sat, 4 May 2019 15:11:49 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id N10fhlxLKYTGMN10fhq2cc; Sat, 04 May 2019 15:11:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XeAi899fhFvlLlp/YRR7n/Jsn9TTM/OdnmeukJZqcUs=; b=x+OAWcacPl1GTNYf3HezBdYCY3 36vSdD5mdM/2odbHjyb8oOAiKDAZCxOKye9v/QIdAazUyLaBauaPDrujIk34Bdo9t+0ArKSRuKgwb E4dUF1kxHOFaWxHncGYjWWu4C; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:39978 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hN10f-004Jf3-GI; Sat, 04 May 2019 15:11:49 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [FYI 2/7] Change valid_command_p to return bool Date: Sat, 4 May 2019 14:11:42 -0600 Message-Id: <20190504201147.3095-3-tom@tromey.com> In-Reply-To: <20190504201147.3095-1-tom@tromey.com> References: <20190504201147.3095-1-tom@tromey.com> This changes valid_command_p to return bool. gdb/ChangeLog 2019-05-04 Tom Tromey * cli/cli-cmds.c (valid_command_p): Return bool. --- gdb/ChangeLog | 4 ++++ gdb/cli/cli-cmds.c | 6 +++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 5f3b973f060..3d8e2387ff7 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -1355,9 +1355,9 @@ argv_to_string (char **argv, int n) } /* Subroutine of alias_command to simplify it. - Return TRUE if COMMAND exists, unambiguously. Otherwise FALSE. */ + Return true if COMMAND exists, unambiguously. Otherwise false. */ -static int +static bool valid_command_p (const char *command) { struct cmd_list_element *c; @@ -1365,7 +1365,7 @@ valid_command_p (const char *command) c = lookup_cmd_1 (& command, cmdlist, NULL, 1); if (c == NULL || c == (struct cmd_list_element *) -1) - return FALSE; + return false; /* This is the slightly tricky part. lookup_cmd_1 will return a pointer to the last part of COMMAND