Make process_stratum_target::stratum "final"

Message ID 20190418154334.12507-1-tromey@adacore.com
State New, archived
Headers

Commit Message

Tom Tromey April 18, 2019, 3:43 p.m. UTC
  It seemed to me that process_stratum_target::stratum ought to be
"final".

Tested by rebuilding, let me know what you think.

gdb/ChangeLog
2019-04-18  Tom Tromey  <tromey@adacore.com>

	* process-stratum-target.h (class process_stratum_target)
	<stratum>: Add "final".
---
 gdb/ChangeLog                | 5 +++++
 gdb/process-stratum-target.h | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)
  

Comments

Pedro Alves April 18, 2019, 4:31 p.m. UTC | #1
On 4/18/19 4:43 PM, Tom Tromey wrote:
> It seemed to me that process_stratum_target::stratum ought to be
> "final".
> 
> Tested by rebuilding, let me know what you think.
> 

Makes sense.

Thanks,
Pedro Alves
  

Patch

diff --git a/gdb/process-stratum-target.h b/gdb/process-stratum-target.h
index fd308658fbb..2e620f82e8a 100644
--- a/gdb/process-stratum-target.h
+++ b/gdb/process-stratum-target.h
@@ -29,7 +29,7 @@  class process_stratum_target : public target_ops
 public:
   ~process_stratum_target () override = 0;
 
-  strata stratum () const override { return process_stratum; }
+  strata stratum () const final override { return process_stratum; }
 
   /* We must default these because they must be implemented by any
      target that can run.  */