diff mbox

Make "all" depend on "info"

Message ID 20190406204834.23321-1-tom@tromey.com
State New
Headers show

Commit Message

Tom Tromey April 6, 2019, 8:48 p.m. UTC
I've broken "make info" a couple of times now, because I sometimes
forget to run "make info" after modifying a Texinfo file.

I don't know why gdb's "make all" doesn't build the info pages.  I
suspect this was some Cygnus-local oddity back in the day.

This patch changes doc/Makefile.in so that the info pages are built by
"make all".  As a point of reference, Automake has essentially always
worked this way.  According to the Automake manual (I didn't
double-check) this is required by the GNU coding standards.

The first time I sent this patch, I mentioned that I wanted to look
into some existing bugs in bugzilla about missing "makeinfo".
However, today I tried and I discovered that BFD requires makeinfo,
and builds its info file as part of "all".  So, I think this change
doesn't worsen the situation for users in any way, and can simply go
in.

gdb/doc/ChangeLog
2019-04-06  Tom Tromey  <tom@tromey.com>

	* Makefile.in (all): Depend on "info".
---
 gdb/doc/ChangeLog   | 4 ++++
 gdb/doc/Makefile.in | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

Comments

Eli Zaretskii April 7, 2019, 2:34 a.m. UTC | #1
> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>
> Date: Sat,  6 Apr 2019 14:48:34 -0600
> 
> This patch changes doc/Makefile.in so that the info pages are built by
> "make all".  As a point of reference, Automake has essentially always
> worked this way.  According to the Automake manual (I didn't
> double-check) this is required by the GNU coding standards.
> 
> The first time I sent this patch, I mentioned that I wanted to look
> into some existing bugs in bugzilla about missing "makeinfo".
> However, today I tried and I discovered that BFD requires makeinfo,
> and builds its info file as part of "all".  So, I think this change
> doesn't worsen the situation for users in any way, and can simply go
> in.

Fine with me, but did you verify the prerequisites won't cause the
manual rebuilt when not necessary?  IOW, does INFO_DEPS include
anything except the Texinfo sources?

Thanks.
Tom Tromey April 7, 2019, 11:04 p.m. UTC | #2
Eli> Fine with me, but did you verify the prerequisites won't cause the
Eli> manual rebuilt when not necessary?  IOW, does INFO_DEPS include
Eli> anything except the Texinfo sources?

No, it doesn't.  I'm checking it in.

Tom
diff mbox

Patch

diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
index 39c94dc82bc..2bb8a3051bb 100644
--- a/gdb/doc/Makefile.in
+++ b/gdb/doc/Makefile.in
@@ -182,7 +182,7 @@  HAVE_NATIVE_GCORE_TARGET = @HAVE_NATIVE_GCORE_TARGET@
 
 ###
 
-all:
+all: info
 
 info: $(INFO_DEPS)
 dvi: gdb.dvi stabs.dvi refcard.dvi annotate.dvi