Message ID | 20190406204834.23321-1-tom@tromey.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 102293 invoked by alias); 6 Apr 2019 20:48:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 102275 invoked by uid 89); 6 Apr 2019 20:48:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-17.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_RP_RNBL, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1416, day X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.195.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 06 Apr 2019 20:48:38 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 8191B400C8285 for <gdb-patches@sourceware.org>; Sat, 6 Apr 2019 15:05:56 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id CsEvhbI8JdnCeCsEvhQ4PH; Sat, 06 Apr 2019 15:48:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version :Content-Type:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KPVgDWPORtKgLtVIRPkiLIzoIsXMDgA93LZH9ynE9N0=; b=CB8CgHVWsDeHh32SXyjftSgNqZ HeTPdUbK3OsO5o5zHvvusHNqSQnT07MJTA/wogC4JnxcUCZQq8JqswRLYjd2RmIfkYbhoMnGsY8IM jC4qqz9J1EFQ3+f6IWU4GgQ0U; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:47518 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from <tom@tromey.com>) id 1hCsEv-002w26-Bi; Sat, 06 Apr 2019 15:48:37 -0500 From: Tom Tromey <tom@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey <tom@tromey.com> Subject: [PATCH] Make "all" depend on "info" Date: Sat, 6 Apr 2019 14:48:34 -0600 Message-Id: <20190406204834.23321-1-tom@tromey.com> |
Commit Message
Tom Tromey
April 6, 2019, 8:48 p.m. UTC
I've broken "make info" a couple of times now, because I sometimes forget to run "make info" after modifying a Texinfo file. I don't know why gdb's "make all" doesn't build the info pages. I suspect this was some Cygnus-local oddity back in the day. This patch changes doc/Makefile.in so that the info pages are built by "make all". As a point of reference, Automake has essentially always worked this way. According to the Automake manual (I didn't double-check) this is required by the GNU coding standards. The first time I sent this patch, I mentioned that I wanted to look into some existing bugs in bugzilla about missing "makeinfo". However, today I tried and I discovered that BFD requires makeinfo, and builds its info file as part of "all". So, I think this change doesn't worsen the situation for users in any way, and can simply go in. gdb/doc/ChangeLog 2019-04-06 Tom Tromey <tom@tromey.com> * Makefile.in (all): Depend on "info". --- gdb/doc/ChangeLog | 4 ++++ gdb/doc/Makefile.in | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-)
Comments
> From: Tom Tromey <tom@tromey.com> > Cc: Tom Tromey <tom@tromey.com> > Date: Sat, 6 Apr 2019 14:48:34 -0600 > > This patch changes doc/Makefile.in so that the info pages are built by > "make all". As a point of reference, Automake has essentially always > worked this way. According to the Automake manual (I didn't > double-check) this is required by the GNU coding standards. > > The first time I sent this patch, I mentioned that I wanted to look > into some existing bugs in bugzilla about missing "makeinfo". > However, today I tried and I discovered that BFD requires makeinfo, > and builds its info file as part of "all". So, I think this change > doesn't worsen the situation for users in any way, and can simply go > in. Fine with me, but did you verify the prerequisites won't cause the manual rebuilt when not necessary? IOW, does INFO_DEPS include anything except the Texinfo sources? Thanks.
Eli> Fine with me, but did you verify the prerequisites won't cause the Eli> manual rebuilt when not necessary? IOW, does INFO_DEPS include Eli> anything except the Texinfo sources? No, it doesn't. I'm checking it in. Tom
diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in index 39c94dc82bc..2bb8a3051bb 100644 --- a/gdb/doc/Makefile.in +++ b/gdb/doc/Makefile.in @@ -182,7 +182,7 @@ HAVE_NATIVE_GCORE_TARGET = @HAVE_NATIVE_GCORE_TARGET@ ### -all: +all: info info: $(INFO_DEPS) dvi: gdb.dvi stabs.dvi refcard.dvi annotate.dvi