From patchwork Wed Apr 3 01:37:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 32136 Received: (qmail 26958 invoked by alias); 3 Apr 2019 01:38:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 26876 invoked by uid 89); 3 Apr 2019 01:38:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=primitive X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.143.234) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Apr 2019 01:38:09 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 4646E36D0C for ; Tue, 2 Apr 2019 20:38:08 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id BUquhr2MH2qH7BUquhFYdW; Tue, 02 Apr 2019 20:38:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5kqXPlGeBmHD6ulZfPdMW2RmMMR6hvg2/gpXpTSPzhA=; b=SVvMXACjMIPJGvtFtHzLtiUJrH sPmObJ6E47zqsJsn5ShwRYjYKuUgBm/UKHpVbjf+O/x/KK6Pjgdip+o7tXNcSvqrlXt0A+7VNgfbu r6vFZB+v9CWRyrjdBxiPeeqIy; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:34720 helo=bapiya.Home) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hBUqu-002Gj6-1A; Tue, 02 Apr 2019 20:38:08 -0500 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 04/13] Turn parse_language into a method Date: Tue, 2 Apr 2019 19:37:56 -0600 Message-Id: <20190403013805.11978-5-tom@tromey.com> In-Reply-To: <20190403013805.11978-1-tom@tromey.com> References: <20190403013805.11978-1-tom@tromey.com> This changes parse_language into a method of parser_state. This patch was written by a script. gdb/ChangeLog 2019-04-02 Tom Tromey * rust-exp.y: Replace "parse_language" with method call. * p-exp.y: (yylex): Replace "parse_language" with method call. * m2-exp.y: (yylex): Replace "parse_language" with method call. * go-exp.y (classify_name): Replace "parse_language" with method call. * f-exp.y (yylex): Replace "parse_language" with method call. * d-exp.y (lex_one_token): Replace "parse_language" with method call. * c-exp.y: (lex_one_token, classify_name, yylex): Replace "parse_language" with method call. * ada-exp.y (find_primitive_type, type_char) (type_system_address): Replace "parse_language" with method call. --- gdb/ChangeLog | 18 ++++++++++ gdb/ada-exp.y | 6 ++-- gdb/c-exp.y | 92 +++++++++++++++++++++++------------------------ gdb/d-exp.y | 2 +- gdb/f-exp.y | 4 +-- gdb/go-exp.y | 2 +- gdb/m2-exp.y | 4 +-- gdb/p-exp.y | 6 ++-- gdb/parser-defs.h | 9 +++-- gdb/rust-exp.y | 4 +-- 10 files changed, 85 insertions(+), 62 deletions(-) diff --git a/gdb/ada-exp.y b/gdb/ada-exp.y index 74dab760cf8..f1c587a9d74 100644 --- a/gdb/ada-exp.y +++ b/gdb/ada-exp.y @@ -1027,7 +1027,7 @@ static struct type* find_primitive_type (struct parser_state *par_state, char *name) { struct type *type; - type = language_lookup_primitive_type (parse_language (par_state), + type = language_lookup_primitive_type (par_state->language (), par_state->gdbarch (), name); if (type == NULL && strcmp ("system__address", name) == 0) @@ -1442,7 +1442,7 @@ type_long_double (struct parser_state *par_state) static struct type * type_char (struct parser_state *par_state) { - return language_string_char_type (parse_language (par_state), + return language_string_char_type (par_state->language (), par_state->gdbarch ()); } @@ -1456,7 +1456,7 @@ static struct type * type_system_address (struct parser_state *par_state) { struct type *type - = language_lookup_primitive_type (parse_language (par_state), + = language_lookup_primitive_type (par_state->language (), par_state->gdbarch (), "system__address"); return type != NULL ? type : parse_type (par_state)->builtin_data_ptr; diff --git a/gdb/c-exp.y b/gdb/c-exp.y index b78851972d1..34e80bfd0bf 100644 --- a/gdb/c-exp.y +++ b/gdb/c-exp.y @@ -815,7 +815,7 @@ exp : SIZEOF '(' type ')' %prec UNARY { struct type *type = $3; write_exp_elt_opcode (pstate, OP_LONG); write_exp_elt_type (pstate, lookup_signed_typename - (parse_language (pstate), + (pstate->language (), pstate->gdbarch (), "int")); type = check_typedef (type); @@ -1284,117 +1284,117 @@ typebase : TYPENAME { $$ = $1.type; } | INT_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "int"); } | LONG - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "long"); } | SHORT - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "short"); } | LONG INT_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "long"); } | LONG SIGNED_KEYWORD INT_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "long"); } | LONG SIGNED_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "long"); } | SIGNED_KEYWORD LONG INT_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "long"); } | UNSIGNED LONG INT_KEYWORD - { $$ = lookup_unsigned_typename (parse_language (pstate), + { $$ = lookup_unsigned_typename (pstate->language (), pstate->gdbarch (), "long"); } | LONG UNSIGNED INT_KEYWORD - { $$ = lookup_unsigned_typename (parse_language (pstate), + { $$ = lookup_unsigned_typename (pstate->language (), pstate->gdbarch (), "long"); } | LONG UNSIGNED - { $$ = lookup_unsigned_typename (parse_language (pstate), + { $$ = lookup_unsigned_typename (pstate->language (), pstate->gdbarch (), "long"); } | LONG LONG - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "long long"); } | LONG LONG INT_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "long long"); } | LONG LONG SIGNED_KEYWORD INT_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "long long"); } | LONG LONG SIGNED_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "long long"); } | SIGNED_KEYWORD LONG LONG - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "long long"); } | SIGNED_KEYWORD LONG LONG INT_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "long long"); } | UNSIGNED LONG LONG - { $$ = lookup_unsigned_typename (parse_language (pstate), + { $$ = lookup_unsigned_typename (pstate->language (), pstate->gdbarch (), "long long"); } | UNSIGNED LONG LONG INT_KEYWORD - { $$ = lookup_unsigned_typename (parse_language (pstate), + { $$ = lookup_unsigned_typename (pstate->language (), pstate->gdbarch (), "long long"); } | LONG LONG UNSIGNED - { $$ = lookup_unsigned_typename (parse_language (pstate), + { $$ = lookup_unsigned_typename (pstate->language (), pstate->gdbarch (), "long long"); } | LONG LONG UNSIGNED INT_KEYWORD - { $$ = lookup_unsigned_typename (parse_language (pstate), + { $$ = lookup_unsigned_typename (pstate->language (), pstate->gdbarch (), "long long"); } | SHORT INT_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "short"); } | SHORT SIGNED_KEYWORD INT_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "short"); } | SHORT SIGNED_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "short"); } | UNSIGNED SHORT INT_KEYWORD - { $$ = lookup_unsigned_typename (parse_language (pstate), + { $$ = lookup_unsigned_typename (pstate->language (), pstate->gdbarch (), "short"); } | SHORT UNSIGNED - { $$ = lookup_unsigned_typename (parse_language (pstate), + { $$ = lookup_unsigned_typename (pstate->language (), pstate->gdbarch (), "short"); } | SHORT UNSIGNED INT_KEYWORD - { $$ = lookup_unsigned_typename (parse_language (pstate), + { $$ = lookup_unsigned_typename (pstate->language (), pstate->gdbarch (), "short"); } | DOUBLE_KEYWORD - { $$ = lookup_typename (parse_language (pstate), + { $$ = lookup_typename (pstate->language (), pstate->gdbarch (), "double", NULL, 0); } | LONG DOUBLE_KEYWORD - { $$ = lookup_typename (parse_language (pstate), + { $$ = lookup_typename (pstate->language (), pstate->gdbarch (), "long double", NULL, @@ -1456,19 +1456,19 @@ typebase $$ = NULL; } | UNSIGNED type_name - { $$ = lookup_unsigned_typename (parse_language (pstate), + { $$ = lookup_unsigned_typename (pstate->language (), pstate->gdbarch (), TYPE_NAME($2.type)); } | UNSIGNED - { $$ = lookup_unsigned_typename (parse_language (pstate), + { $$ = lookup_unsigned_typename (pstate->language (), pstate->gdbarch (), "int"); } | SIGNED_KEYWORD type_name - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), TYPE_NAME($2.type)); } | SIGNED_KEYWORD - { $$ = lookup_signed_typename (parse_language (pstate), + { $$ = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "int"); } /* It appears that this rule for templates is never @@ -1489,7 +1489,7 @@ type_name: TYPENAME { $$.stoken.ptr = "int"; $$.stoken.length = 3; - $$.type = lookup_signed_typename (parse_language (pstate), + $$.type = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "int"); } @@ -1497,7 +1497,7 @@ type_name: TYPENAME { $$.stoken.ptr = "long"; $$.stoken.length = 4; - $$.type = lookup_signed_typename (parse_language (pstate), + $$.type = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "long"); } @@ -1505,7 +1505,7 @@ type_name: TYPENAME { $$.stoken.ptr = "short"; $$.stoken.length = 5; - $$.type = lookup_signed_typename (parse_language (pstate), + $$.type = lookup_signed_typename (pstate->language (), pstate->gdbarch (), "short"); } @@ -2555,7 +2555,7 @@ lex_one_token (struct parser_state *par_state, bool *is_quoted_name) if (strncmp (tokstart, tokentab3[i].oper, 3) == 0) { if ((tokentab3[i].flags & FLAG_CXX) != 0 - && parse_language (par_state)->la_language != language_cplus) + && par_state->language ()->la_language != language_cplus) break; lexptr += 3; @@ -2568,7 +2568,7 @@ lex_one_token (struct parser_state *par_state, bool *is_quoted_name) if (strncmp (tokstart, tokentab2[i].oper, 2) == 0) { if ((tokentab2[i].flags & FLAG_CXX) != 0 - && parse_language (par_state)->la_language != language_cplus) + && par_state->language ()->la_language != language_cplus) break; lexptr += 2; @@ -2612,7 +2612,7 @@ lex_one_token (struct parser_state *par_state, bool *is_quoted_name) case '(': paren_depth++; lexptr++; - if (parse_language (par_state)->la_language == language_objc + if (par_state->language ()->la_language == language_objc && c == '[') return OBJC_LBRAC; return c; @@ -2710,7 +2710,7 @@ lex_one_token (struct parser_state *par_state, bool *is_quoted_name) { const char *p = &tokstart[1]; - if (parse_language (par_state)->la_language == language_objc) + if (par_state->language ()->la_language == language_objc) { size_t len = strlen ("selector"); @@ -2862,7 +2862,7 @@ lex_one_token (struct parser_state *par_state, bool *is_quoted_name) if (strcmp (copy, ident_tokens[i].oper) == 0) { if ((ident_tokens[i].flags & FLAG_CXX) != 0 - && parse_language (par_state)->la_language != language_cplus) + && par_state->language ()->la_language != language_cplus) break; if ((ident_tokens[i].flags & FLAG_SHADOW) != 0) @@ -2871,7 +2871,7 @@ lex_one_token (struct parser_state *par_state, bool *is_quoted_name) if (lookup_symbol (copy, expression_context_block, VAR_DOMAIN, - (parse_language (par_state)->la_language + (par_state->language ()->la_language == language_cplus ? &is_a_field_of_this : NULL)).symbol != NULL) @@ -2940,7 +2940,7 @@ classify_name (struct parser_state *par_state, const struct block *block, memset (&is_a_field_of_this, 0, sizeof (is_a_field_of_this)); bsym = lookup_symbol (copy, block, VAR_DOMAIN, - parse_language (par_state)->la_name_of_this + par_state->language ()->la_name_of_this ? &is_a_field_of_this : NULL); if (bsym.symbol && SYMBOL_CLASS (bsym.symbol) == LOC_BLOCK) @@ -2999,7 +2999,7 @@ classify_name (struct parser_state *par_state, const struct block *block, } /* See if it's an ObjC classname. */ - if (parse_language (par_state)->la_language == language_objc && !bsym.symbol) + if (par_state->language ()->la_language == language_objc && !bsym.symbol) { CORE_ADDR Class = lookup_objc_class (par_state->gdbarch (), copy); if (Class) @@ -3038,7 +3038,7 @@ classify_name (struct parser_state *par_state, const struct block *block, yylval.ssym.is_a_field_of_this = is_a_field_of_this.type != NULL; if (bsym.symbol == NULL - && parse_language (par_state)->la_language == language_cplus + && par_state->language ()->la_language == language_cplus && is_a_field_of_this.type == NULL && lookup_minimal_symbol (copy, NULL, NULL).minsym == NULL) return UNKNOWN_CPP_NAME; @@ -3147,7 +3147,7 @@ yylex (void) if (current.token == NAME) current.token = classify_name (pstate, expression_context_block, is_quoted_name, last_lex_was_structop); - if (parse_language (pstate)->la_language != language_cplus + if (pstate->language ()->la_language != language_cplus || (current.token != TYPENAME && current.token != COLONCOLON && current.token != FILENAME)) return current.token; diff --git a/gdb/d-exp.y b/gdb/d-exp.y index 73d5cfc368a..50c8325d46a 100644 --- a/gdb/d-exp.y +++ b/gdb/d-exp.y @@ -1288,7 +1288,7 @@ lex_one_token (struct parser_state *par_state) return DOLLAR_VARIABLE; yylval.tsym.type - = language_lookup_primitive_type (parse_language (par_state), + = language_lookup_primitive_type (par_state->language (), par_state->gdbarch (), copy); if (yylval.tsym.type != NULL) return TYPENAME; diff --git a/gdb/f-exp.y b/gdb/f-exp.y index 499de419222..ca407786080 100644 --- a/gdb/f-exp.y +++ b/gdb/f-exp.y @@ -1276,7 +1276,7 @@ yylex (void) result = lookup_symbol (tmp, expression_context_block, lookup_domains[i], - parse_language (pstate)->la_language + pstate->language ()->la_language == language_cplus ? &is_a_field_of_this : NULL); if (result.symbol && SYMBOL_CLASS (result.symbol) == LOC_TYPEDEF) @@ -1290,7 +1290,7 @@ yylex (void) } yylval.tsym.type - = language_lookup_primitive_type (parse_language (pstate), + = language_lookup_primitive_type (pstate->language (), pstate->gdbarch (), tmp); if (yylval.tsym.type != NULL) return TYPENAME; diff --git a/gdb/go-exp.y b/gdb/go-exp.y index 35f480abe81..3f564cf6d90 100644 --- a/gdb/go-exp.y +++ b/gdb/go-exp.y @@ -1400,7 +1400,7 @@ classify_name (struct parser_state *par_state, const struct block *block) copy = copy_name (yylval.sval); /* Try primitive types first so they win over bad/weird debug info. */ - type = language_lookup_primitive_type (parse_language (par_state), + type = language_lookup_primitive_type (par_state->language (), par_state->gdbarch (), copy); if (type != NULL) diff --git a/gdb/m2-exp.y b/gdb/m2-exp.y index c78e03fab95..611981fd9c2 100644 --- a/gdb/m2-exp.y +++ b/gdb/m2-exp.y @@ -596,7 +596,7 @@ variable: NAME type : TYPENAME - { $$ = lookup_typename (parse_language (pstate), + { $$ = lookup_typename (pstate->language (), pstate->gdbarch (), copy_name ($1), expression_context_block, 0); } @@ -968,7 +968,7 @@ yylex (void) sym = lookup_symbol (tmp, expression_context_block, VAR_DOMAIN, 0).symbol; if (sym && SYMBOL_CLASS (sym) == LOC_BLOCK) return BLOCKNAME; - if (lookup_typename (parse_language (pstate), pstate->gdbarch (), + if (lookup_typename (pstate->language (), pstate->gdbarch (), copy_name (yylval.sval), expression_context_block, 1)) return TYPENAME; diff --git a/gdb/p-exp.y b/gdb/p-exp.y index d4b315061b0..79b2979f6a7 100644 --- a/gdb/p-exp.y +++ b/gdb/p-exp.y @@ -591,7 +591,7 @@ exp : THIS write_exp_elt_opcode (pstate, OP_THIS); /* We need type of this. */ this_val - = value_of_this_silent (parse_language (pstate)); + = value_of_this_silent (pstate->language ()); if (this_val) this_type = value_type (this_val); else @@ -731,7 +731,7 @@ variable: name_not_typename write_exp_elt_opcode (pstate, STRUCTOP_PTR); /* We need type of this. */ this_val - = value_of_this_silent (parse_language (pstate)); + = value_of_this_silent (pstate->language ()); if (this_val) this_type = value_type (this_val); else @@ -1675,7 +1675,7 @@ yylex (void) return TYPENAME; } yylval.tsym.type - = language_lookup_primitive_type (parse_language (pstate), + = language_lookup_primitive_type (pstate->language (), pstate->gdbarch (), tmp); if (yylval.tsym.type != NULL) { diff --git a/gdb/parser-defs.h b/gdb/parser-defs.h index 1aa5f1ff2e3..8fcbca36bb1 100644 --- a/gdb/parser-defs.h +++ b/gdb/parser-defs.h @@ -32,8 +32,6 @@ struct internalvar; extern int parser_debug; -#define parse_language(ps) ((ps)->expout->language_defn) - struct parser_state { /* Constructor. LANG is the language used to parse the expression. @@ -55,6 +53,13 @@ struct parser_state return expout->gdbarch; } + /* Return the language that was passed to the constructor. */ + + const struct language_defn *language () + { + return expout->language_defn; + } + /* The size of the expression above. */ size_t expout_size; diff --git a/gdb/rust-exp.y b/gdb/rust-exp.y index 60eb6172f03..9b6ca199436 100644 --- a/gdb/rust-exp.y +++ b/gdb/rust-exp.y @@ -205,7 +205,7 @@ struct rust_parser /* Return the parser's language. */ const struct language_defn *language () const { - return parse_language (pstate); + return pstate->language (); } /* Return the parser's gdbarch. */ @@ -2280,7 +2280,7 @@ rust_parser::convert_ast_to_expression (const struct rust_op *operation, { struct type *type; - type = language_lookup_primitive_type (parse_language (pstate), + type = language_lookup_primitive_type (pstate->language (), pstate->gdbarch (), "()");